Skip to content

Notify user when connecting as follower fails#19477

Merged
seanbudd merged 5 commits intonvaccess:betafrom
tareh7z:add-follower-connection-error-notifications-beta
Jan 21, 2026
Merged

Notify user when connecting as follower fails#19477
seanbudd merged 5 commits intonvaccess:betafrom
tareh7z:add-follower-connection-error-notifications-beta

Conversation

@tareh7z
Copy link
Copy Markdown
Contributor

@tareh7z tareh7z commented Jan 20, 2026

Link to issue number:

Replaces #19454
Replaces #19467
Fixes #19103

Summary of the issue:

Users are not notified when connecting as the controlled computer (follower) fails. Only the leader connection errors are shown to users.

Description of user facing changes:

Users will now see an error message when connection as the controlled computer fails, just like when connecting as the controlling computer.

Description of developer facing changes:

None.

Description of development approach:

Made follower connection error handling consistent with leader connection by adding the missing event handler and user notification.

  • Added onConnectAsFollowerFailed method in client.py to handle follower connection failures;
  • Registered transportConnectionFailed event handler for follower transport;
  • Added cleanup for event handlers in disconnectAsFollower method.

Testing strategy:

Tested manually.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@tareh7z tareh7z requested a review from a team as a code owner January 20, 2026 11:24
@tareh7z tareh7z requested a review from seanbudd January 20, 2026 11:24
Comment thread user_docs/en/changes.md Outdated
Comment thread source/_remoteClient/client.py Outdated
@seanbudd seanbudd added this to the 2026.1 milestone Jan 21, 2026
@seanbudd seanbudd enabled auto-merge (squash) January 21, 2026 05:07
@seanbudd seanbudd changed the title Notify user when connecting as follower fails (#19454) #19467 Notify user when connecting as follower fails Jan 21, 2026
@seanbudd seanbudd disabled auto-merge January 21, 2026 05:48
@seanbudd seanbudd merged commit 8b37367 into nvaccess:beta Jan 21, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants