changed magnifier uninitialize#20069
Draft
Boumtchack wants to merge 5 commits into
Draft
Conversation
Contributor
|
In the first days of NVDA magnifier, we may have to do as follows, either to compare both magnifiers or in case of a still unknown bug in NVDA magnifier:
I am afraid we won't be able to do so anymore. Do you confirm this? If yes, isn't it possible to find another solution? |
SaschaCowley
changed the title
Member
|
I think work on this should be blocked/suspended until #20051 is merged |
Contributor
|
Please note that the target branch for this PR and some other PRs has been changed to beta, so when merging upstream changes, please choose to merge the beta branch instead of the master branch. |
Contributor
Author
|
ah yeah, didn't see that, I'll make the changes |
…A grids in focus mode. (nvaccess#20091) Fixes nvaccess#17750. Summary of the issue: When moving to an ARIA grid cell in focus mode in web browsers, NVDA previously reported both the row and column headers even if only the row or only the column changed. Description of user facing changes: When moving to an ARIA grid cell in focus mode in web browsers, NVDA no longer reports both the row and column headers even if only the row or only the column changed. Description of development approach: Previously, there were two problems: After c4c3da6 (BrowseModeDocumentTextInfo.getControlFieldSpeech: Report the name of groupings (such as fieldsets) for quicknav and focus jumps, similar to how landmark labels are reported. nvaccess#7435), Browse mode was updating the speech properties cache before speaking the focused object, even in focus mode. That meant that the row and column coordinates for the newly focused cell were already cached before NVDA spoke it, which made NVDA behave as if the coordinates never changed. The fix is to update the cache from the TextInfo after speaking the focused object. Virtual buffers just used the IA2 unique id as the table id, but NVDAObjects use both the window handle and id, meaning that these didn't compare correctly in the speech cache. The fix is to make the vbuf normalize table ids to windowHandle and id.
…t value is no longer considered the default. (nvaccess#20156) Summary of the issue: Currently, the issue template submits the first option in the single-select dropdown as the default value. If the issue template is not filled out correctly when submitting an issue, these default values may mislead us in assessing the issue. Description of user facing changes: When submitting an issue, users need to select their answers more clearly. Description of developer facing changes: Description of development approach: Reorder the dropdown options in the issue template so that the default value is no longer considered the default.
Boumtchack
force-pushed
the
fix/MagnifierStartup
branch
from
222d74a to
8283661
Compare
seanbudd
added
the
conceptApproved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fix #20068
Summary of the issue:
Stopping and restarting the fullscreen magnifier fails with OSError: [WinError 0] from MagSetFullscreenTransform.
Description of user facing changes:
The fullscreen magnifier can now be stopped and restarted reliably.
Description of developer facing changes:
Description of development approach:
The MagInitialize → MagUninitialize → MagInitialize cycle within the same process causes MagSetFullscreenTransform to silently return FALSE with no error code. The fix keeps the API initialized for the NVDA session lifetime and defers MagUninitialize() to shutdown.
Testing strategy:
manual
Known issues with pull request:
Code Review Checklist: