Revert "Notify user when connecting as follower fails (#19477)"#20131
Merged
Conversation
seanbudd
approved these changes
May 15, 2026
SaschaCowley
force-pushed
the
revert-19477
branch
from
f4a3d07 to
bcbbb1c
Compare
Member
Author
|
@seanbudd I wasn't sure whether to document this as a change or a bug fix. Technically it's not a bug, but users might expect it to be documented as one. |
seanbudd
reviewed
May 15, 2026
seanbudd
reviewed
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR
Reverts #19477
Issues fixed
Fixes #20122
Issues reopened
Reopens #19103
Reason for revert
The referenced commit breaks the use-case where the user is using NVDA Remote Access as their primary means of accessing a headless or otherwise physically inaccessible machine, if the network is unavailable when Remote Access attempts the initial connection.
Can this PR be reimplemented? If so, what is required for the next attempt
Yes. For automatic connections, continue to retry establishing the connection indefinitely, or with some configurable timeout.