Use Windows date preferences in Add-on Store#20539
Open
islambenmebarekdz-collab wants to merge 1 commit into
Open
Use Windows date preferences in Add-on Store#20539islambenmebarekdz-collab wants to merge 1 commit into
islambenmebarekdz-collab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19681
Summary of the issue:
The Add-on Store formats publication and installation dates with Python's
%x. NVDA sets the process locale to its interface language, so the Arabic interface selects the Saudi Arabic calendar and displays Hijri dates even when the user configured Windows to use Gregorian dates.Description of user facing changes:
Publication and installation dates in the Add-on Store now follow the user's Windows regional and calendar settings instead of the NVDA interface language.
Description of developer facing changes:
A reusable
formatDateForSystemLocalehelper formats dates through the existingwinKernel.GetDateFormatExwrapper withLOCALE_NAME_USER_DEFAULT. All Add-on Store date display paths use this helper.Description of development approach:
The change replaces
%xin the Add-on Store model, list view model, and details control. This retains localized short-date formatting while allowing Windows—not NVDA's UI locale—to select the user's preferred locale and calendar.Testing strategy:
Arabic_Saudi Arabia: 21 July 2026 formatted through%xas07/02/1448.21/07/2026, matching this Windows user's configured regional and Gregorian calendar settings.LOCALE_NAME_USER_DEFAULTand the supplied date.runlint.batandruncheckpot.batsuccessfully.Known issues with pull request:
None known.
Code Review Checklist: