Beta#20558
Open
andavag wants to merge 3 commits into
Open
Conversation
…vaccess#20425) The "Custom" value in DecimalSeparatorOption had no UI to configure it and was never forwarded to MathCAT, whose DecimalSeparator preference only accepts Auto, "." and ",". Remove the enum member and its label, fix the stale configSpec comment, and add the missing User Guide section for the setting (providing the MathSpeechDecimalSeparator anchor the settings dialog links to). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove non-functional "Custom" option from MathCAT decimal separator …
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #20425
Summary of the issue:
In the Math settings panel, the "Decimal separator for numbers" setting offered a "Custom" option that did nothing; the suggested solution was to remove the option.
Description of user facing changes:
Removed the non-functional "Custom" choice from the "Decimal separator for numbers" combo box in Math settings. The remaining choices are Automatic, "." and ",".
Description of developer facing changes:
None
Description of development approach:
CUSTOM = "Custom"enum member and its translators label fromDecimalSeparatorOptioninsource/mathPres/MathCAT/preferences.py.source/config/configSpec.pyfrom# Auto, '.', ',', Customto# Auto, '.', ','to reflect the available options.###### Decimal separator for numbers {#MathSpeechDecimalSeparator}touser_docs/en/userGuide.md, placed between the "Language" and "Speech Style" options. This provides documentation for the setting and supplies the help anchor that the settings dialog references.user_docs/en/changes.md.Testing strategy:
Known issues with pull request:
None
Code Review Checklist: