Conversation
Fixes #20746 Summary of the issue: "Show entire screen overview" feature bricks the magnifier when relative tracking mode is enabled Description of user facing changes: Spotlight works when using relative tracking mode Description of developer facing changes: none Description of development approach: Fix int conversion
Link to issue number: Closes #20103 Summary of the issue: Small bump to espeak Description of user facing changes: minor espeak bug fixes Description of developer facing changes: n/a Description of development approach: No compile files were changed, just minor fixes to existing voices
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Spotlight start animation still targets a zoom value inconsistent with the percentage-based zoom model, which can desynchronize internal zoom state and affect subsequent animations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR synchronizes release/beta changes into master by updating dependency documentation (eSpeak NG commit) and fixing NVDA Magnifier spotlight “Show entire screen overview” behavior when using relative tracking mode, with corresponding unit test updates.
Changes:
- Update eSpeak NG commit references in user-facing release notes and developer environment docs.
- Fix spotlight zoom-back logic for relative tracking mode and adjust zoom value handling.
- Update magnifier spotlight unit tests to match zoom level semantics (percentage-based).
File summaries
| File | Description |
|---|---|
| user_docs/en/changes.md | Updates release notes (eSpeak NG commit) and documents the magnifier spotlight fix. |
| tests/unit/test_magnifier/test_spotlightManager.py | Updates unit tests to use integer percentage zoom levels and to cover relative-mode zoom-back behavior. |
| source/_magnifier/utils/spotlightManager.py | Fixes spotlight zoom-back behavior in relative mode and adjusts zoom value casting. |
| projectDocs/dev/createDevEnvironment.md | Updates the documented eSpeak NG submodule commit. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Start the spotlight | ||
| """ | ||
| self._originalZoomLevel = self._fullscreenMagnifier.zoomLevel | ||
| self._originalZoomLevel = int(self._fullscreenMagnifier.zoomLevel) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.