Language handler: use kernel32.dll function, add Kurdish language support #8538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g kernel32.dll's LocaleNameToLCID function. Re nvaccess#8488. Because NVDA no longer supports Windows XP, it is now safe to call kernel32.dll's LocaleNameToLCID function directly in language handler. This function is used for obtaining language descriptions and from Windows OneCore synthesizer for perfomring language switch command (Windows 10 only).
…, add Kurdish family. The following languages have LCID's defined in Windows 7 and later: Amharic (am), Arabic (ar), Nepali (ne), Latin Serbian (sr). Aragonese is kept because no LCID is defined. Added Kurdish family: Central (ckb), Northern (kmr). The general code, 'ku', is defined in Windows 10 for Central Kurdish, and two letter country code does not work at this stage. This also means the docstring for language description retriever has been changed to say that three-letter language codes are also accepted.
Member
|
Were you able to test that all the LCIDs we used to have listed really
are supported on Windows 7?
|
Contributor
Author
|
Hi, Yes:
I believe those are the LCID's that were not supported on older releases. If I recall correctly, these were added specifically for Windows XP users way back in 2013. Thanks. |
Contributor
Author
|
Hi, Forgot to add Amharic, which is also supported on Windows 7. Thanks. |
michaelDCurran
approved these changes
Jul 23, 2018
Collaborator
|
@josephsl: Could you please close the associated issues by hand that can be closed because of the merge of this pr? |
Contributor
Author
|
Hi, sure, will take care of that in just a second. Thanks.
From: Leonard de Ruijter <notifications@github.com>
Sent: Sunday, July 22, 2018 11:03 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Language handler: use kernel32.dll function, add Kurdish language support (#8538)
@josephsl <https://github.com/josephsl> : Could you please close the associated issues by hand that can be closed because of the merge of this pr?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#8538 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkLrTj8tkMnPJ8Lu_UqGGMzTKEIu9ks5uJWcVgaJpZM4VaXJR> .
|
|
Not sure it was due to this, but today's alpha update stopped all speech on
reboot. I had to stop the machine on its on off button then restart,
whereupon it then worked as normal.
Would this perhaps be a one off issue with this update?
Brian
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#8488, #8489, #8490
Summary of the issue:
Updates language handler to use kernel32 function, remove LCID's supported on Windows 7 and later as they are included by default, add Kurdish language support.
Description of how this pull request fixes the issue:
Updates language handler:
Testing performed:
Tested on Windows 7, 8.1 and 10, along with adding Kurdish locale files.
Known issues with pull request:
None
Change log entry:
None (for now as Kurdish language files are not really ready yet).
Thanks.