speech.speakObjectProperties: if removing the 'selected' state, make sure to copy the states set first as to not mutate the cache for future state change announcements#8900
Merged
michaelDCurran merged 1 commit intomasterfrom Nov 1, 2018
Conversation
…sure to copy the states set first as to not mutate the cache for future state change announcements.
LeonarddeR
approved these changes
Nov 1, 2018
Collaborator
LeonarddeR
left a comment
LeonarddeR
left a comment
There was a problem hiding this comment.
Code looks good and works as expected 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8903
Summary of the issue:
With the merging of pr #8898, NVDA has started announcing 'selected' if the focused control has the selected state when another state changes.
For example, In Thunderbird when collapsing or expanding an email account in the mail folders treeview.
Description of how this pull request fixes the issue:
This PR makes sure to copy the states set in speakObjectProperties before removing the 'selected' and 'selectable' states. This is so that the cached states are not affected. Otherwise, when a state change occurs, NVDA would think that selected and selectable were added back in.
Testing performed:
Collapsed and expanded an email account in Thunderbird mail folders treeview.
Known issues with pull request:
None.
Change log entry:
None needed.
Section: New features, Changes, Bug fixes