Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up of: Don't announce 'selected' when the focus moves in Google sheets if the focused cell is the only cell selected #8898

Merged
merged 7 commits into from Oct 31, 2018

Conversation

michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Oct 31, 2018

Fix up of pr #8879.
Contains one last commit which ensures this change is only limited to focusable items, such as ARIA gridcells. This is necessary as otherwise 'not selected' is reported for standard html tables both in focus and browse modes.

Testing performed:

Same as PR #8879, but also:

  • Arrowing up and down a standard html table in browse mode
  • Object navigation between cells in a standard html table
  • Moving focus up and down a list (NVDA punctuation settings dialog
  • Moving up and down a treeview (File Explorer)

@michaelDCurran michaelDCurran requested a review from feerrenrut Oct 31, 2018
… childID coming from accSelection, as found in QT tree tables like in Mumble
@michaelDCurran michaelDCurran merged commit b02ed2d into master Oct 31, 2018
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Oct 31, 2018
@leonardder
Copy link
Collaborator

@leonardder leonardder commented Oct 31, 2018

I"m getting messages like "selected expanded" or "selected collapsed" when expanding or collapsing folders in the thunderbird tree view. I don't consider it very relevant, but it is definitely caused by this pr, I think.

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jul 15, 2019
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jul 15, 2019
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Aug 13, 2019
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
michaelDCurran pushed a commit that referenced this issue Sep 11, 2019
…in Google sheets if the focused cell is the only cell selected (#8898) (#10080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants