Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the extended window style on Window objects #9136

Merged
merged 1 commit into from Apr 11, 2019

Conversation

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jan 9, 2019

Link to issue number:

None

Summary of the issue:

For application Windows, the window style can be fetched to find out whether the window has a title bar, is visible or unavailable. The extended window style wasn't yet available on Window objects. The extended window style provides information like:

  • Whether the window supports dragging and dropping of files
  • Whether the window is a window within an MDI interface
  • Whether the window text is displayed using right-to-left reading-order properties
  • Whether the window is a floating toolbar
  • Whether the window is transparent
  • The window is always on top

Description of how this pull request fixes the issue:

Implements the extendedWindowStyle property and adds it to the developer info

Testing performed:

Tested using several windows. IN many cases, the extended window style is 0. However, not for the notepad foreground window, for example.

Known issues with pull request:

None

Change log entry:

  • Changes for developers
    • The extended window style of a window is now exposed using the extendedWindowStyle property on Window objects and their derivatives.
@leonardder leonardder requested a review from feerrenrut Jan 9, 2019
@leonardder leonardder changed the title Exposes the extended window style on Window objects Expose the extended window style on Window objects Jan 9, 2019
Copy link
Member

@feerrenrut feerrenrut left a comment

Great!

@feerrenrut feerrenrut merged commit 8f54d22 into nvaccess:master Apr 11, 2019
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone Apr 11, 2019
feerrenrut added a commit that referenced this issue Apr 11, 2019
The extended window style of a window is now exposed using the `extendedWindowStyle` property on Window objects and their derivatives. (PR #9136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants