Fix up of: Fix up of: Don't announce 'selected' when the focus moves in Google sheets if the focused cell is the only cell selected (#8898)#9930
Closed
JulienCochuyt wants to merge 1 commit intonvaccess:masterfrom
Conversation
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
f16ce99 to
b464c43
Compare
Contributor
Author
|
b464c43: Rebased onto latest master. |
Contributor
Author
JulienCochuyt
added a commit
to accessolutions/WebAccessForNVDA
that referenced
this pull request
Jul 17, 2019
Collaborator
|
@JulienCochuyt strangely this PR seems closed by you but in Github insights it appears like it is still open. So is this still valid? Are you working on it? |
Contributor
Author
The branch has erroneously been pruned while syncing our fork. |
Contributor
Author
|
Reopened as PR #10080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9520
Fixes #7292 (comment) (only the error log in the comment, not the whole issue).
Faulty behavior introduced as of b02ed2d (#8898)
Summary of the issue:
MSHTML._get_tablehistorically raises aNotImplementedErrorwhen there is no surrounding table.IAccessible._get_table, on the other hand, returnsNonein the same situation.IAccessible._get_selectionContainer, introduced by b02ed2d, callsself.tablewhich can lead to the following error log:Description of how this pull request fixes the issue:
Return
Noneinstead of raisingNotImplementedErrorinMSHTML._get_table, in coherence with its base class.Testing performed:
Browsed with IE11 under Windows 10 to (http://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html) (which is the test case of #9520 and report focus on the example tab header.
Known issues with pull request:
This approach can theoretically break existing assumption of the method raising the exception, but other IAccessible implementation have been recently much more tested and return
Nonein the same case.So, I guess it is safer to apply the proposed change than to track every single call to
_get_tableand enclose in atry...exceptblock, with the risk of missing a few of them in the process.Change log entry:
Section: Bug fixes
NVDA is no longer silent when focusing an HTML tab header in Internet Explorer.