inject-helper64.exe no longer resolves relative graphics-hook paths in 32.2.0. Intended?

[Segergren]

My program uses libobs, and after updating to 32.2.0 (Windows) game capture stopped hooking. All I got in the log was Warning: [game-capture: 'gameplay'] inject process failed: -4. The exact same setup worked fine in 32.1.2.

Turns out PR #11569 added SetDllDirectoryW(L"") and safe search mode to inject-helper, which drops the current directory from DLL resolution. So LoadLibraryW() in inject_library_safe_obf() can't resolve a relative graphics-hook path anymore, returns NULL, and the helper exits -4.

It comes down to the path OBS ends up passing to the hook (from the module data path I register). Same file, only the form differs:

graphics-hook path handed to inject-helper	result
.\data\obs-plugins\win-capture\graphics-hook64.dll (relative)	-4
C:\segra\data\obs-plugins\win-capture\graphics-hook64.dll (absolute)	works

Regular OBS isn't affected since it always passes absolute paths. I've fixed my side by registering an absolute module data path so obs_module_file() returns absolute.

Is dropping relative-path support here intended, i.e. embedders should always pass absolute paths?

[notr1ch]

Yes, this is the intended path now that we're using safer DLL loading, relative paths are not supported and anything relying on the current directory is also due to be phased out (3rd party DLLs can randomly change the current directory so it's not safe to rely on).

Ideally obs_open_module should always receive absolute module and data paths to prevent relative path components slipping in to generated paths.

[Segergren]

Makes sense, thanks. Fixed on my side by resolving to absolute before passing them in