Cannot drag-&-drop sources, dragging scenes deletes them when using browser panels

[xurei]

Operating System Info

Other

Other OS

Manjaro Linux

OBS Studio Version

27.0.0-rc1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/sw-7ofvWAMM1fHMa

OBS Studio Crash Log URL

No response

Expected Behavior

On OBS 26, it was possible to move sources in the sources list with drag-and-drop.

It was also the only way (that I know of) to put a source in an existing group.

Current Behavior

On OBS 27, it does not work anymore.

Steps to Reproduce

[EDIT 2021-05-14] I made a video highlighting the problem : https://www.youtube.com/watch?v=QGDVaOUOr1s

Moving sources

1. Create a blank scene with two sources (whichever should work)
2. Try to move the upper source down using drag-and-drop
3. It should not work

Putting sources in group

1. Create a blank scene with a source and a group
2. Try to put the source in the group using drag-and-drop
3. It should not work

Anything else we should know?

I've taken a look in the logs and didn't see any kind of error...

[WizardCM]

I can confirm this on Ubuntu 20.04. Worse, if you try and drag scenes after reproducing this issue, it straight up deletes the scene.

[awarus]

Ubuntu 18.04 5.4.0-70-generic #78~18.04.1-Ubuntu SMP is OK (with both 27.0.0-rc1 and 27.0.0-rc2) with different scenarios. May affect some libqt on this(my version is 5)? Like manipulating in UI with QDrag objects and modes?

[RytoEX]

Ubuntu 18.04 has Qt 5.9.5. Ubuntu 20.04 has Qt 5.12.8. I believe Manjaro should have Qt 5.15.2.

[xurei]

@RytoEX Confirmed : Qt 5.15.2 on Manjaro

$ qtdiag
Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 10.2.0) on "xcb" 
OS: Manjaro Linux [linux version 5.10.23-1-MANJARO]
...

[RytoEX]

For what it's worth, so far I cannot reproduce this on Windows 10 with OBS Studio 27.0.0-rc1 or 27.0.0-rc2. I also cannot reproduce this in a Ubuntu 20.04 VM with OBS Studio 27.0.0-rc2.

[WizardCM]

After performing a bisect to try and track down when this issue was introduced, git bisect told me the following:

90ab876cc727a1d9ef89a32f065fa25efc17f98 is the first bad commit
commit 190ab876cc727a1d9ef89a32f065fa25efc17f98
Merge: e8a1c082d e67fdbca7
Author: Jim <obs.jim@gmail.com>
Date:   Fri Feb 12 01:30:05 2021 -0800

    Merge pull request #2484 from GeorgesStavracas/feaneron/egl-wayland
    
    EGL/Wayland (Wayland, pt 3)

However, now that I've finished the bisect & after returning HEAD to master, I can no longer reproduce this issue.

I can only assume that either

1. a stale built file stuck around from somewhere and introduced the issue
2. a stale cmake flag stuck around from somewhere and introduced the issue

Would you be willing to do the following?

1. Clone a second copy of the obs-studio repo and try building it clean from current master

And if that doesn't have the same issue, would you be able to dump your cmake config/flags from the "broken" variant?

I'd do it myself but wasn't expecting the issue to magically disappear and I now have no way to reproduce this issue.

[RytoEX]

@xurei How did you install this version of OBS Studio? What variant and version of Manjaro are you running?

[kkartaltepe]

I also cannot replicate on Arch Linux, on-top of 00fdec2

[RytoEX]

I'm leaning towards some scene collection file/data corruption, possibly from undo/redo, and that corruption snowballing into other issues like this. I think it's possible that this issue has since been resolved (or perhaps simply masked) by code changes made since then.

As far as I can tell, "OBS 27.0.0.rc1.r26.gc37069277" would be commit c370692. Here is the comparison between that commit and RC2: c370692...27.0.0-rc2

In that diff, you'll see the following:

• bab2188
• 2932cd0

There are even more changes since then. I'd recommend:

1. Testing on commit c370692 with a clean scene collection to see if it's able to be reproduced there to validate these reproduction steps.
2. Testing on the current master (or RC3 when it's out) with a clean scene collection to see if it can still be reproduced there.

[xurei]

@RytoEX It's installed it through AUR (https://aur.archlinux.org/packages/obs-studio-git/).
I just checked its PKGBUILD and the only thing that seems to be different from a build from source is a patch unrelated with this issue (something about loading python binary modules)

I just made an update and the problem is still there.
Version installed : 27.0.0.rc3.r15.g54db450e4

[rogue-ronin]

Saw a link to this in discord chat, thought I'd check it out. I just installed obs-studio-git in Manjaro Linux (27.0.0.rc3.r48.gca88ba8bb)

I can drag-n-drop, move into group, move out of group, reorder in group, reorder group within Sources list. No errors at all.

I tried this both before and after updating Manjaro to the latest weekly version.
Kernel: 5.12.1-2-MANJARO

So... 🤷‍♀️ perhaps it's local?

[xurei]

@rogue-ronin I just updated OBS to 27.0.0.rc4.r3.g5fcffb066
The problem is still present.

What is the version of Qt that you get with qtdiag ?

[RytoEX]

@rogue-ronin I just updated OBS to 27.0.0.rc4.r3.g5fcffb066
The problem is still present.

What is the version of Qt that you get with qtdiag ?

Can you please clarify if this is reproducible with a clean scene collection?