Skip to content

Conversation

@pkviet
Copy link
Member

@pkviet pkviet commented Dec 10, 2024

Description

This fixes a bug where the NVIDIA NVAFX filters are migrated but not kept in their original order, with respect to other filters.

Motivation and Context

Fixes a bug.
The bug was noticed by @Penwy whom I thank for the info.

How Has This Been Tested?

Tested on windows 11 pro 24H2, with an RTX 4090 GPU.
The filter order is kept during migration of NVIDIA audio FX.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@pkviet pkviet added the Bug Fix Non-breaking change which fixes an issue label Dec 10, 2024
@RytoEX RytoEX added this to the OBS Studio 31 milestone Dec 10, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should use a verb as the first word:

obs-filters: Maintain order of migrated NVAFX filters

If you've tested this for various filter placements (first, last, middle of 3, middle of more than 3), then this seems fine.

@RytoEX RytoEX self-assigned this Dec 10, 2024
This fixes a bug where the NVIDIA NVAFX filters are migrated but not
kept in their original order, with respect to other filters.

Signed-off-by: pkv <pkv@obsproject.com>
@pkviet
Copy link
Member Author

pkviet commented Dec 10, 2024

The commit message should use a verb as the first word:

obs-filters: Maintain order of migrated NVAFX filters

Done

If you've tested this for various filter placements (first, last, middle of 3, middle of more than 3), then this seems fine.

yeah, tested in orders 1, 2, 3 & 4 in a set of 4 filters; works fine.

@pkviet pkviet changed the title obs-filters: For migrated NVAFX filters, fix order obs-filters: Maintain order of migrated NVAFX filters Dec 10, 2024
@RytoEX RytoEX merged commit 69a825b into obsproject:master Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants