obs-filters: Add compressor gain reduction meter - #13737
Conversation
Expose applied gain reduction from the compressor and show a live meter in the Filters dialog so users can tune by eye.
|
Hmm, generally I'd expect the reduction to be visualised from the right/top of the bar, not the left/bottom. At least personally. Additionally, I believe it's preferred that new Qt widgets are constructed using |
|
This appears at first glance to be AI created/assisted which goes against our contribution guidelines. There are a variety of snippets that also do not conform to our codestyle rules. Even in the case that it is not however, on merit alone this is still being hacked into the properties UI in this current implementation. The properties API is simply not designed for describing bespoke UI elements like this. Any such functionality would need to start with a proper architectural change to allow this. |
|
Well it's more effort than anyone else has made to get this very basic and expected feature into the app. I give up, maybe someone else can take up the reigns |
Description
Adds a real-time gain reduction meter for the Compressor filter.
The compressor already computed applied gain per sample but never exposed it. This PR:
get_gain_reductionproc handlerThis should be able to be applied to other dynamics filters as well.
Motivation and Context
Speaking as a professional audio engineer for over 15 years, this is a standard feature on all compressors. Without gain reduction feedback, the compressor must be tuned by ear alone, which is neither accurate nor intuitive. Output level meters don’t show how much reduction is actually being applied. This has come up from users before, e.g. forum and ideas.
How Has This Been Tested?
windows-x64)Types of changes
Checklist: