frontend: Use styling for source items visual appearance - #13833
Merged
Conversation
Updates idian utils to also support QLabel widgets for icon coloring.
The icon and text label for items in the source list was previously enabled/disabled based on scene item visibility state. As of Qt 6.11 Qt no longer triggers context menus when right clicking a disabled QLabel. This means right-clicking a hidden scene item would not show a context menu. Updates SourceTreeItem to use styling classes via idian helpers instead of changing the enabled state of these labels.
Warchamp7
added
the
area/ui-ux
RytoEX
added
kind/bug
PatTheMav
approved these changes
Sep 1, 2026
RytoEX
approved these changes
Sep 1, 2026
github-project-automation
Bot
moved this from Ready For Review
to Merged
in 33.0 Release Tracker
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The icon and text label for items in the sources list was previously enabled/disabled based on the scene item visibility state. As of Qt 6.11 Qt no longer triggers context menus when right clicking a disabled QLabel. This means right-clicking a hidden scene item on the source icon or name would not show a context menu.
Updates SourceTreeItem to use styling classes via idian helpers instead of changing the enabled state of these labels.
Motivation and Context
Fixes context menus not appearing for hidden scene items when clicking certain regions of the source list.
How Has This Been Tested?
Toggled scene item visibility and right-clicked on sources in the sources list.
Types of changes
Checklist: