Skip to content

obs-transitions: Track Matte fixes for Source Visibility transitions#4549

Merged
jp9000 merged 2 commits into
obsproject:masterfrom
Palakis:bugfix/stinger-track-matte-scaling-clipping
Apr 19, 2021
Merged

obs-transitions: Track Matte fixes for Source Visibility transitions#4549
jp9000 merged 2 commits into
obsproject:masterfrom
Palakis:bugfix/stinger-track-matte-scaling-clipping

Conversation

@Palakis
Copy link
Copy Markdown
Contributor

@Palakis Palakis commented Apr 18, 2021 •
edited
Loading

Description

  • When resolutions on the source and stinger don't match, the Matte texture is rescaled before being provided to the Matte shader. This results in a Matte smaller than the textures it is supposed to cover
  • When using a Track Matte Stinger as a visibility transition, side-by-side and stacked file modes will render the full texture (both the stinger side and the matte side) instead of cropping it to only show the stinger side.

Motivation and Context

Fixes this: https://obsproject.com/forum/threads/obs-studio-27-release-candidate.141857/page-2#post-522508

How Has This Been Tested?

Tested on Windows 10 20H2, with a 1920x1080 Track Matte Stinger running as the visibility transition of a 1024x768 source (either an image or a video).

Types of changes

  • Bug fix (non-breaking change which fixes an issue) -->

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label Apr 18, 2021
@Palakis Palakis marked this pull request as ready for review April 18, 2021 02:58
Palakis added 2 commits April 18, 2021 17:38
@Palakis @jp9000
obs-transitions: Remove scaling of track matte texture
941695e
@Palakis @jp9000
obs-transitions: Crop output of stinger media player
55d5d6f 
This fixes an issue with Track Matte Stingers applied as visibility
transitions, where the side-by-side or stacked matte file mode would
result in the matte part of the video to "overflow" outside of the
transition's zone
@jp9000 jp9000 merged commit dc2b00a into obsproject:master Apr 19, 2021
@RytoEX RytoEX added this to the OBS Studio 27.0 milestone Apr 19, 2021
@jpark37 jpark37 mentioned this pull request May 2, 2021
Merged
6 tasks
@Palakis Palakis deleted the bugfix/stinger-track-matte-scaling-clipping branch May 4, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

OBS Studio 27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Palakis @RytoEX @WizardCM @jp9000