UI: Stop locking filter mutex while loading properties#5759
Merged
Conversation
Reordering the filters makes the filter mutex of the source locked while loading a new the properties of a filter which may require other locks. By loading the properties of the filter on a QueuedConnection we make sure the filter mutex is cleared when that happens.
eab130e to
e832262
Compare
Member
|
Is this a new issue in the beta, or slightly more longer-standing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reordering the filters makes the filter mutex of the source locked while loading a new the properties of a filter which may require other locks. By loading the properties of the filter on a QueuedConnection we make sure the filter mutex is cleared when that happens.
Motivation and Context
I don't like deadlocks.
The main UI thread gets a lock on the filter mutex followed by a lock on the app sources mutex to fill the properties of the filter
while the graphics thread does a lock on the app sources mutex followed by a lock on the filter mutex
How Has This Been Tested?
On windows 64 bit by reordering move transition override filters
Types of changes
Checklist: