Skip to content

Set desktopFileName for QApplication#5778

Merged
WizardCM merged 1 commit intoobsproject:masterfrom
nicolasfella:desktopfilename
Jan 16, 2022
Merged

Set desktopFileName for QApplication#5778
WizardCM merged 1 commit intoobsproject:masterfrom
nicolasfella:desktopfilename

Conversation

@nicolasfella
Copy link
Copy Markdown
Contributor

This needs to matcht the base name of the .desktop file name.

This is needed for propagating the correct app id on Wayland,
which is needed e.g. for proper window icons on Plasma Wayland

@notr1ch
Copy link
Copy Markdown
Member

notr1ch commented Jan 12, 2022

Please read the commit guidelines and fill out the PR template.

@WizardCM
Copy link
Copy Markdown
Member

Additionally, as we don't use the name "com.obsproject.Studio" outside of Flatpak, it may be worth scoping this.

This needs to match the base name of the .desktop file name.

This is needed for propagating the correct App ID on Wayland,
which is needed e.g. for proper window icons on Plasma.
@WizardCM WizardCM merged commit f43b046 into obsproject:master Jan 16, 2022
@RytoEX RytoEX added this to the OBS Studio 27.2 milestone Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants