Set desktopFileName for QApplication#5778
Merged
WizardCM merged 1 commit intoobsproject:masterfrom Jan 16, 2022
Merged
Conversation
Member
|
Please read the commit guidelines and fill out the PR template. |
Member
|
Additionally, as we don't use the name "com.obsproject.Studio" outside of Flatpak, it may be worth scoping this. |
This needs to match the base name of the .desktop file name. This is needed for propagating the correct App ID on Wayland, which is needed e.g. for proper window icons on Plasma.
a72b8ad to
844caf8
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to matcht the base name of the .desktop file name.
This is needed for propagating the correct app id on Wayland,
which is needed e.g. for proper window icons on Plasma Wayland