Skip to content

UI: Fix padding with vertical volume meters#7026

Merged
jp9000 merged 1 commit intoobsproject:masterfrom
cg2121:volume-meter-padding
Aug 13, 2022
Merged

UI: Fix padding with vertical volume meters#7026
jp9000 merged 1 commit intoobsproject:masterfrom
cg2121:volume-meter-padding

Conversation

@cg2121
Copy link
Copy Markdown
Contributor

@cg2121 cg2121 commented Aug 10, 2022

Description

Since Yami uses a different font, the 0 dB mark at the top of the
vertical meters would be cut off. This adds a 1px padding to the top
and bottom of the volume meters, when in vertical mode.

Before:
Screenshot from 2022-08-10 11-31-28

After:
Screenshot from 2022-08-10 11-29-58

Motivation and Context

Fixes #6961

How Has This Been Tested?

Put volume meters in vertical mode to see if the 0 dB mark was cut off or not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Since Yami uses a different font, the 0 dB mark at the top of the
vertical meters would be cut off. This adds a 1px padding to the top
and bottom of the volume meters, when in vertical mode.
@cg2121 cg2121 added the Bug Fix Non-breaking change which fixes an issue label Aug 10, 2022
@cg2121 cg2121 added this to the OBS Studio 28.0 milestone Aug 10, 2022
@jp9000 jp9000 merged commit 9418940 into obsproject:master Aug 13, 2022
@cg2121 cg2121 deleted the volume-meter-padding branch May 1, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

[28.0.0-beta1] Vertical volume sliders cut off the 0db "0" (padding issue)

2 participants