Skip to content

UI: Add scene grid mode to view menu#8231

Merged
Lain-B merged 1 commit intoobsproject:masterfrom
cg2121:view-menu-grid-mode
May 21, 2023
Merged

UI: Add scene grid mode to view menu#8231
Lain-B merged 1 commit intoobsproject:masterfrom
cg2121:view-menu-grid-mode

Conversation

@cg2121
Copy link
Copy Markdown
Contributor

@cg2121 cg2121 commented Feb 8, 2023

Description

Makes toggling of the scene list grid mode also available in the view menu.

Screenshot 2023-02-08 04-36-55

Motivation and Context

Not just in a context menu.

How Has This Been Tested?

Toggled grid mode in the view menu.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements. labels Feb 8, 2023
@cg2121 cg2121 requested a review from Warchamp7 February 8, 2023 10:47
Copy link
Copy Markdown
Member

@Warchamp7 Warchamp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionList and actionGrid feel a bit too generic to me naming-wise but otherwise fine

@cg2121 cg2121 added this to the OBS Studio 29.1 milestone Mar 21, 2023
@RytoEX
Copy link
Copy Markdown
Member

RytoEX commented Mar 26, 2023

actionList and actionGrid feel a bit too generic to me naming-wise but otherwise fine

What about one of these sets:

  • actionSceneListView
  • actionSceneGridView

or:

  • actionSceneListViewEnable
  • actionSceneGridViewEnable

Makes toggling of the scene list grid mode also available in the
view menu.
@cg2121 cg2121 force-pushed the view-menu-grid-mode branch from 137a6e6 to f4d02cf Compare March 26, 2023 08:54
@cg2121
Copy link
Copy Markdown
Contributor Author

cg2121 commented Mar 26, 2023

Updated it to actionSceneGridMode and actionSceneListMode

@Lain-B Lain-B merged commit 3a53882 into obsproject:master May 21, 2023
@cg2121 cg2121 deleted the view-menu-grid-mode branch May 1, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants