Skip to content

UI: Remove platform string from title bar#8371

Merged
WizardCM merged 1 commit intoobsproject:masterfrom
cg2121:remove-platform
Mar 17, 2023
Merged

UI: Remove platform string from title bar#8371
WizardCM merged 1 commit intoobsproject:masterfrom
cg2121:remove-platform

Conversation

@cg2121
Copy link
Copy Markdown
Contributor

@cg2121 cg2121 commented Feb 28, 2023

Description

This cleans up the title bar text.

Motivation and Context

Doesn't seem necessary to have in the title bar.

How Has This Been Tested?

Looked at title bar.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
Copy link
Copy Markdown
Member

RytoEX commented Feb 28, 2023

Personally, I appreciate being able to tell at a glance of the title bar what the user's actual system is. Do we have this string in About somewhere?

@RytoEX RytoEX added the Code Cleanup Non-breaking change which makes code smaller or more readable label Mar 2, 2023
@WizardCM
Copy link
Copy Markdown
Member

WizardCM commented Mar 4, 2023

Realised this removes the platform from more places than we'd like, including the log file, the User Agent in CURL calls (including the updater, maybe?). We might have to have a includePlatform parameter and conditionally include the platform.

This cleans up the title bar text.
@cg2121 cg2121 force-pushed the remove-platform branch from 0960b70 to fde2fa4 Compare March 5, 2023 12:45
@cg2121
Copy link
Copy Markdown
Contributor Author

cg2121 commented Mar 5, 2023

Updated to include parameter about platform.

@cg2121 cg2121 requested a review from WizardCM March 5, 2023 12:46
@WizardCM WizardCM merged commit a870ae2 into obsproject:master Mar 17, 2023
@RytoEX RytoEX added this to the OBS Studio 29.1 milestone Mar 17, 2023
@RytoEX RytoEX mentioned this pull request Mar 31, 2023
6 tasks
@cg2121 cg2121 deleted the remove-platform branch May 1, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Cleanup Non-breaking change which makes code smaller or more readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants