mac-virtualcam: Correct device timer firing rate#9768
Merged
Conversation
19ffb98 to
4fa8dfc
Compare
Member
|
That was indeed my mistake, the original example code correctly uses |
PatTheMav
approved these changes
Oct 27, 2023
|
@PatTheMav Do you happen to know when a new release candidate with this fix is going to be published? I'd like to try it |
Member
|
It's a critical fix, so we'll probably try to get it in as soon as possible. |
RytoEX
approved these changes
Oct 27, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves the conversion to a Double in
OBSCameraDeviceSource, such that the virtual camera device timer fires correctly every1/60seconds, instead of trying to fire every0seconds.Motivation and Context
Resolves #9760. CPU use was very high with the new virtual camera extension at idle and while active because of the amount of polling the device timer was doing.
How Has This Been Tested?
Tested locally on my machine. Reduced camera extension process CPU use by roughly 10x.
Types of changes
Checklist: