Master analytic improvement tbe by qdp-odoo · Pull Request #17499 · odoo/odoo

qdp-odoo · 2017-06-08T12:38:29Z

Task

https://www.odoo.com/web#id=32386&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

PR: https://github.com/odoo/enterprise/pull/1100
PR: #17499

qdp-odoo

first pass done. some changes are required though you're on the right track :)

qdp-odoo · 2017-06-08T12:39:14Z

these 2 functions should be removed since we want that on analytic lines (not account.move.line)

qdp-odoo · 2017-06-08T12:39:22Z

qdp-odoo · 2017-06-08T12:39:39Z

qdp-odoo · 2017-06-08T12:48:43Z

must refactor the cancellation of account.move to unlink all the analytic lines created (even with a distribution).

Otherwise, currently you're duplicating the analytic entries each time you cancel-revalidate a journal entry

qdp-odoo · 2017-06-08T12:50:15Z

remove the currency computation

+set explicitly the company_id

qdp-odoo · 2017-06-08T13:01:40Z

to remove entirely

qdp-odoo · 2017-06-08T13:04:57Z

line['amount_user_currency'] += r['amount_user_currency']

qdp-odoo · 2017-06-08T13:05:28Z

required=True

qdp-odoo · 2017-06-08T13:07:33Z

group_analytic_accounting

qdp-odoo · 2017-06-08T13:07:46Z

dead code to remove

xmo-odoo · 2017-06-09T07:58:51Z

Why not move.mapped('line_ids.analytic_line_ids').unlink()? That will remove all analytic entries in a single unlink call.

xmo-odoo · 2017-06-09T08:00:25Z

"Or" between a leaf and nothing? That doesn't seem correct.

Could you enlight me please, would something like this be better?

@api.model def name_search(self, name, args=None, operator='ilike', limit=100): if name: recs = self.search([('account_id', operator, name)] + (args or []), limit=limit) return recs.name_get() return super(AccountAnalyticDistribution, self).search(domain, limit=limit).name_get()

I don't know what you're trying to do, the original just doesn't make any sense. The new version is at least syntactically correct.

Well, qdp asked me to remove the 'name' field from the model and to use account_id's name for the search.

OK, the version you posted in your comment makes more sense then.

xmo-odoo · 2017-06-09T08:01:02Z

Why copy the context twice?

xmo-odoo · 2017-06-09T08:01:22Z

Just call .with_context(date=line.date), there's no need to do any context copy.

xmo-odoo · 2017-06-09T08:02:43Z

That strikes me as a pointless optimisation, the only thing it potentially saves is a rounding (which you can disable with round=True anyway).

xmo-odoo · 2017-06-09T08:05:09Z

Why not call it domain? And why the list conversion?

I can't call it domain since there's already a parameter named domain, the list is pointless ?

Should I do ?

__domain = '__domain' in line and line['__domain'] or []

xmo-odoo · 2017-06-09T08:05:22Z

Use sum()?

xmo-odoo · 2017-06-09T08:05:43Z

Why all the spaces?

Bad habits, sorry.

fixed

- Categories can now be set to analytic account. - Analytic tags can now be used on journal entries without the need to activate analytic acounting. task: https://www.odoo.com/web#id=32386&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

- Added the ability to create a hierarchy to categories. - Analytic tags are now fully independent to Analytic Accounting and can be activited through the settings.

…cy/multi-company. - Added Analytic Distribution to analytic tags, Analytic Accounting and Analytic Tags must be activated. - Analytic moves are now linked to the user's company. - Analytic Analysis & analytic move are now expressed in user's currency. - Analytic Accounts do not require anymore linking them to a company.

- Added the ability to use analytic tags on analytic default. - Removed field 'analytic_amount_currency' from account analytic line.

- The childrens are now displayed anymore for categories. - The categories are now displayed with this format 'Parent n°1 / Parent n°2 / Parent n°X / Name'

…ies can now be set to analytic account. - Analytic tags can now be used on journal entries without the need to activate analytic acounting.

qdp-odoo commented Jun 8, 2017

View reviewed changes

xmo-odoo reviewed Jun 9, 2017

View reviewed changes

xmo-odoo previously requested changes Jun 9, 2017

View reviewed changes

C3POdoo added the RD research & development, internal work label Jun 9, 2017

tbe-odoo force-pushed the master-analytic-improvement-tbe branch from 1f49cd4 to 2af953c Compare June 9, 2017 10:36

tbe-odoo force-pushed the master-analytic-improvement-tbe branch from b4664c6 to eeaec6c Compare August 10, 2017 13:12

tbe-odoo added 9 commits November 27, 2017 13:19

[IMP] analytic account: Improve analytic arrangement

f76e782

- Added the ability to create a hierarchy to categories. - Analytic tags are now fully independent to Analytic Accounting and can be activited through the settings.

[IMP] analytic account: Fixed review returns

46785e3

[IMP] analytic account: Fix reviews

37b4b2e

[IMP] Analytic account: Fix reviews #3

988bc68

[IMP] analytic account: Fixed filters on analytic lines pivot

3ad037e

[IMP] analytic account: Analytic tags on analytic default.

a95ff96

- Added the ability to use analytic tags on analytic default. - Removed field 'analytic_amount_currency' from account analytic line.

[IMP] analytic: UI improvement

4a6530c

- The childrens are now displayed anymore for categories. - The categories are now displayed with this format 'Parent n°1 / Parent n°2 / Parent n°X / Name'

tbe-odoo force-pushed the master-analytic-improvement-tbe branch from eeaec6c to 4a6530c Compare November 27, 2017 12:36

fixup! [IMP] analytic account: Improve analytic arrangement - Categor…

5901ef0

…ies can now be set to analytic account. - Analytic tags can now be used on journal entries without the need to activate analytic acounting.

tbe-odoo closed this Mar 22, 2018

tbe-odoo deleted the master-analytic-improvement-tbe branch March 22, 2018 17:50

Uh oh!

Conversation

qdp-odoo commented Jun 8, 2017 • edited by antonylesuisse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qdp-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbe-odoo Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xmo-odoo Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbe-odoo Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

qdp-odoo commented Jun 8, 2017 •

edited by antonylesuisse

Loading

tbe-odoo Jun 9, 2017 •

edited

Loading

xmo-odoo Jun 9, 2017 •

edited

Loading

tbe-odoo Jun 9, 2017 •

edited

Loading