Modularize negotiation tests and fix client doc links#1591
Merged
Conversation
2 tasks
oferchen
added a commit
that referenced
this pull request
May 5, 2026
Design note for #1591. Proposes a TransferChannel trait that exposes both sync and async send/recv surfaces, with flume as the recommended backing for sync-async bridge sites and crossbeam retained for the pure-sync hot paths. Documents the five migration sites, backpressure and fairness semantics, cancellation footguns, and follow-up work. Wire-compat impact: zero. Channels are internal coordination only.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
…ine (#3647) Design note for #1591. Proposes a TransferChannel trait that exposes both sync and async send/recv surfaces, with flume as the recommended backing for sync-async bridge sites and crossbeam retained for the pure-sync hot paths. Documents the five migration sites, backpressure and fairness semantics, cancellation footguns, and follow-up work. Wire-compat impact: zero. Channels are internal coordination only.
oferchen
added a commit
that referenced
this pull request
May 5, 2026
) Specifies a hybrid model where a tokio async accept loop hands off accepted connections to a fixed-size pool of synchronous worker threads via a bounded channel. Transfer state machine and wire format are unchanged; the design only replaces the accept-and-dispatch layer. Tracking #1674. References #1591 (async-channel abstraction), #1934/#1935 (async-daemon feature gate), #2052 (TLS termination).
3 tasks
4 tasks
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…ine (#3647) Design note for #1591. Proposes a TransferChannel trait that exposes both sync and async send/recv surfaces, with flume as the recommended backing for sync-async bridge sites and crossbeam retained for the pure-sync hot paths. Documents the five migration sites, backpressure and fairness semantics, cancellation footguns, and follow-up work. Wire-compat impact: zero. Channels are internal coordination only.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
) Specifies a hybrid model where a tokio async accept loop hands off accepted connections to a fixed-size pool of synchronous worker threads via a bounded channel. Transfer state machine and wire format are unchanged; the design only replaces the accept-and-dispatch layer. Tracking #1674. References #1591 (async-channel abstraction), #1934/#1935 (async-daemon feature gate), #2052 (TLS termination).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testsmodule through a lightweightmod.rsshim that re-exports the existing helper importscrates/core/src/client/mod.rsTesting
https://chatgpt.com/codex/tasks/task_e_69028b4e34a88323a677becc1236576c