Skip to content

Decompose CLI filter rule handling#1780

Merged
oferchen merged 1 commit into
masterfrom
prepare-for-production-release-optimization
Oct 31, 2025
Merged

Decompose CLI filter rule handling#1780
oferchen merged 1 commit into
masterfrom
prepare-for-production-release-optimization

Conversation

@oferchen
Copy link
Copy Markdown
Owner

Summary

  • split the oversized CLI filter rule helper into dedicated modules for argument discovery, directive parsing, merge handling, and source loading
  • refresh the hygiene configuration and contributor guidance to point at the new filter_rules module layout

Testing

  • cargo check -p rsync-cli

https://chatgpt.com/codex/tasks/task_e_690528496734832390cf9d7effb1c14c

@oferchen oferchen merged commit 060b7a3 into master Oct 31, 2025
@oferchen oferchen deleted the prepare-for-production-release-optimization branch October 31, 2025 21:36
oferchen added a commit that referenced this pull request May 7, 2026
Document runtime choice (tokio vs smol vs async-std) for any future
async SSH transport. Distinct from #1593 (async I/O on the SSH path).
Cross-references #1779 (tokio scope audit) and #1780 (single-runtime
invariant); recommends tokio + russh, deferred behind --features
embedded-ssh.
oferchen added a commit that referenced this pull request May 16, 2026
Expand the placeholder async migration plan into a comprehensive,
opinionated design covering: current synchronous threading model per
subsystem, per-subsystem cost/benefit, a phased incremental adoption
strategy, tokio runtime choice with rejected alternatives, sync/async
bridge patterns, backward-compat strategy, risk register, and open
questions.

Cross-references existing async-related tasks (#1367, #1411, #1591,
#1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805,
#1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related
design notes so future planners have a single anchor.
oferchen added a commit that referenced this pull request May 16, 2026
Expand the placeholder async migration plan into a comprehensive,
opinionated design covering: current synchronous threading model per
subsystem, per-subsystem cost/benefit, a phased incremental adoption
strategy, tokio runtime choice with rejected alternatives, sync/async
bridge patterns, backward-compat strategy, risk register, and open
questions.

Cross-references existing async-related tasks (#1367, #1411, #1591,
#1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805,
#1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related
design notes so future planners have a single anchor.
oferchen added a commit that referenced this pull request May 18, 2026
Document runtime choice (tokio vs smol vs async-std) for any future
async SSH transport. Distinct from #1593 (async I/O on the SSH path).
Cross-references #1779 (tokio scope audit) and #1780 (single-runtime
invariant); recommends tokio + russh, deferred behind --features
embedded-ssh.
oferchen added a commit that referenced this pull request May 18, 2026
Expand the placeholder async migration plan into a comprehensive,
opinionated design covering: current synchronous threading model per
subsystem, per-subsystem cost/benefit, a phased incremental adoption
strategy, tokio runtime choice with rejected alternatives, sync/async
bridge patterns, backward-compat strategy, risk register, and open
questions.

Cross-references existing async-related tasks (#1367, #1411, #1591,
#1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805,
#1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related
design notes so future planners have a single anchor.
oferchen added a commit that referenced this pull request May 18, 2026
Expand the placeholder async migration plan into a comprehensive,
opinionated design covering: current synchronous threading model per
subsystem, per-subsystem cost/benefit, a phased incremental adoption
strategy, tokio runtime choice with rejected alternatives, sync/async
bridge patterns, backward-compat strategy, risk register, and open
questions.

Cross-references existing async-related tasks (#1367, #1411, #1591,
#1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805,
#1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related
design notes so future planners have a single anchor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant