Conversation
This was referenced Apr 24, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ca956eb3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
force-pushed
the
pr19392
branch
2 times, most recently
from
62541d0 to
32a2927
Compare
bolinfest
force-pushed
the
pr19391
branch
2 times, most recently
from
2ec2407 to
e04981b
Compare
bolinfest
force-pushed
the
pr19392
branch
2 times, most recently
from
37ef901 to
f805b17
Compare
bolinfest
force-pushed
the
pr19391
branch
2 times, most recently
from
bbddc8e to
c4451a1
Compare
bolinfest
force-pushed
the
pr19392
branch
2 times, most recently
from
1b98ec5 to
e8e9902
Compare
viyatb-oai
reviewed
Apr 25, 2026
bolinfest
force-pushed
the
pr19391
branch
2 times, most recently
from
61bde65 to
cdbbfa4
Compare
bolinfest
force-pushed
the
pr19392
branch
2 times, most recently
from
c8335d2 to
f64334a
Compare
bolinfest
force-pushed
the
pr19391
branch
2 times, most recently
from
71ce357 to
bb278c3
Compare
bolinfest
added a commit
that referenced
this pull request
Apr 25, 2026
## Why `PermissionProfile` is now the canonical permissions shape after #19231 because it can distinguish `Managed`, `Disabled`, and `External` enforcement while also carrying filesystem rules that legacy `SandboxPolicy` cannot represent cleanly. Core config and session state still needed to accept profile-backed permissions without forcing every profile through the strict legacy bridge, which rejected valid runtime profiles such as direct write roots. ## What Changed - Adds `Permissions.permission_profile` and `SessionConfiguration.permission_profile` as constrained runtime state, while keeping `sandbox_policy` as a legacy compatibility projection. - Introduces profile setters that keep `PermissionProfile`, split filesystem/network policies, and legacy `SandboxPolicy` projections synchronized. - Uses a compatibility projection for requirement checks and legacy consumers instead of rejecting profiles that cannot round-trip through `SandboxPolicy` exactly. - Updates config loading, config overrides, session updates, turn context plumbing, prompt permission text, sandbox tags, and exec request construction to carry profile-backed runtime permissions. - Preserves configured deny-read entries and `glob_scan_max_depth` when command/session profiles are narrowed. - Adds `PermissionProfile::read_only()` and `PermissionProfile::workspace_write()` presets that match legacy defaults. ## Verification - `cargo test -p codex-core direct_write_roots` - `cargo test -p codex-core runtime_roots_to_legacy_projection` - `cargo test -p codex-app-server requested_permissions_trust_project_uses_permission_profile_intent` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/19391). * #19395 * #19394 * #19393 * #19392 * __->__ #19391
bolinfest
force-pushed
the
pr19604
branch
2 times, most recently
from
708b6b7 to
8261305
Compare
viyatb-oai
approved these changes
Apr 26, 2026
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #19391,
PermissionProfileand the split filesystem/network policies could still be stored in parallel. That creates drift risk: a profile can preserve deny globs, external enforcement, or split filesystem entries while a cached projection silently loses those details. This PR makes the profile the runtime source and derives compatibility views from it.What Changed
PermissionsandSessionConfiguration; their accessors now derive from the canonicalPermissionProfile.SandboxPolicysnapshots from profiles only where an older API still needs that field.PermissionProfileinstead ofSandboxPolicyfor auto-approval decisions.Verification
cargo test -p codex-core direct_write_rootscargo test -p codex-core runtime_roots_to_legacy_projectioncargo test -p codex-app-server requested_permissions_trust_project_uses_permission_profile_intentStack created with Sapling. Best reviewed with ReviewStack.