Conversation
This was referenced Apr 24, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c1797f185
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
force-pushed
the
pr19395
branch
2 times, most recently
from
2cdb4ca to
f697657
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
55c2f31 to
7010512
Compare
bolinfest
force-pushed
the
pr19395
branch
2 times, most recently
from
63d386f to
38fc750
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
7642d2e to
5c02727
Compare
bolinfest
force-pushed
the
pr19395
branch
2 times, most recently
from
2f73fca to
4145cae
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
f044efc to
f8fb073
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
a56d7b0 to
2a018fc
Compare
bolinfest
force-pushed
the
pr19395
branch
2 times, most recently
from
f41f672 to
c90fb0c
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
5408197 to
93f49ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Once core execution is profile-backed, user-facing and app-facing surfaces should stop presenting the legacy sandbox projection as authoritative. This is especially important for
ExternalandDisabled, which both look lax through old sandbox-mode summaries but mean different things operationally.What Changed
PermissionProfilefrom the in-process exec client for thread start, resume, and turn start instead of falling back to legacysandboxmode.external-sandboxanddanger-full-accessplus writable-root summaries for managed profiles.Verification
cargo test -p codex-core direct_write_rootscargo test -p codex-core runtime_roots_to_legacy_projectioncargo test -p codex-app-server requested_permissions_trust_project_uses_permission_profile_intentStack created with Sapling. Best reviewed with ReviewStack.