Conversation
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
55c2f31 to
7010512
Compare
bolinfest
force-pushed
the
pr19393
branch
2 times, most recently
from
2665e60 to
79f119e
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
5c02727 to
1bdc3bd
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
f044efc to
f8fb073
Compare
bolinfest
force-pushed
the
pr19393
branch
2 times, most recently
from
8171f53 to
4a21ac5
Compare
This was referenced Apr 25, 2026
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
716b5c9 to
8cfb152
Compare
bolinfest
force-pushed
the
pr19393
branch
2 times, most recently
from
7ef8fba to
a655a3e
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
b9e5dc4 to
a56d7b0
Compare
bolinfest
force-pushed
the
pr19393
branch
2 times, most recently
from
b55d950 to
828b90d
Compare
bolinfest
force-pushed
the
pr19394
branch
2 times, most recently
from
af09a5c to
5408197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several execution paths still converted profile-backed permissions into
SandboxPolicyand then rebuilt runtime permissions from that legacy shape. Those round trips are unnecessary after the preceding PRs and can lose split filesystem semantics. Core approval and escalation should carry the resolved profile directly.What Changed
sandbox_policyfromResolvedPermissionProfile; the resolved permission object now carries the canonicalPermissionProfiledirectly.SandboxPolicybefore rebuilding runtime permissions.SandboxPolicy, not in core permission computation.Verification
cargo test -p codex-core direct_write_rootscargo test -p codex-core runtime_roots_to_legacy_projectioncargo test -p codex-app-server requested_permissions_trust_project_uses_permission_profile_intentStack created with Sapling. Best reviewed with ReviewStack.