Conversation
This was referenced Apr 24, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c1797f185
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2cdb4ca to
f697657
Compare
55c2f31 to
7010512
Compare
63d386f to
38fc750
Compare
7642d2e to
5c02727
Compare
2f73fca to
4145cae
Compare
f044efc to
f8fb073
Compare
5408197 to
93f49ad
Compare
47ce60e to
d958f52
Compare
7937eb3 to
de2513e
Compare
e154f63 to
a9df4bd
Compare
39d56bc to
e422ec7
Compare
This was referenced Apr 25, 2026
This was referenced Apr 26, 2026
This was referenced Apr 26, 2026
viyatb-oai
approved these changes
Apr 27, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now that core execution is profile-backed, the user-facing and app-facing surfaces should stop presenting the legacy sandbox projection as authoritative. This matters for fidelity:
ExternalandDisabledcan both look permissive through old sandbox-mode summaries, but they mean different operational states.What Changed
PermissionProfilefrom the in-process exec client for thread start, resume, and turn start instead of falling back to legacysandboxmode.external-sandboxanddanger-full-accessplus writable-root summaries for managed profiles.external_sandboxbucket for managed full-filesystem profiles with restricted network.Verification
cargo check -p codex-config -p codex-core -p codex-sandboxing -p codex-app-server -p codex-cli -p codex-tuicargo test -p codex-analytics managed_full_disk_with_restricted_network_reports_external_sandboxcargo test -p codex-core direct_write_rootscargo test -p codex-core runtime_roots_to_legacy_projectioncargo test -p codex-app-server requested_permissions_trust_project_uses_permission_profile_intentStack created with Sapling. Best reviewed with ReviewStack.