feat(core): emit canonical dynamic tool call items#31298
Merged
Conversation
This was referenced Jul 6, 2026
pakrym-oai
approved these changes
Jul 7, 2026
owenlin0
force-pushed
the
owen/canonical-dynamic-tool-call-items
branch
2 times, most recently
from
aac2b79 to
1661367
Compare
owenlin0
force-pushed
the
owen/canonical-command-execution-items
branch
from
16ac27f to
1ec93f2
Compare
owenlin0
force-pushed
the
owen/canonical-dynamic-tool-call-items
branch
from
1661367 to
9036b0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #31296 for the canonical-to-legacy event mappings.
Description
This PR makes dynamic tools emit canonical
TurnItem::DynamicToolCalllifecycle instead ofDynamicToolCallRequest/DynamicToolCallResponsedirectly.App-server v2 now sends the client
DynamicToolCallrequest from the canonical item start. It ignores the mapped legacy request/response events, so clients receive one item start and one tool request.Why
Dynamic tools are a separate migration boundary because their start event also drives a client request. Keeping that routing change isolated makes it easier to verify that the request still happens exactly once.
What changed