feat(core): emit canonical collab tool call items#31300
Merged
Conversation
This was referenced Jul 6, 2026
owenlin0
force-pushed
the
owen/canonical-sub-agent-activity-items
branch
from
fddbaa9 to
7e9e806
Compare
owenlin0
force-pushed
the
owen/canonical-collab-tool-call-items
branch
2 times, most recently
from
fb2e419 to
7744a91
Compare
owenlin0
force-pushed
the
owen/canonical-sub-agent-activity-items
branch
from
7e9e806 to
122f1c9
Compare
owenlin0
force-pushed
the
owen/canonical-sub-agent-activity-items
branch
from
122f1c9 to
3d2cb39
Compare
owenlin0
force-pushed
the
owen/canonical-collab-tool-call-items
branch
from
7744a91 to
760638f
Compare
pakrym-oai
reviewed
Jul 7, 2026
| .await; | ||
| } | ||
|
|
||
| pub(crate) async fn emit_collab_tool_call_completed( |
pakrym-oai
approved these changes
Jul 7, 2026
owenlin0
force-pushed
the
owen/canonical-collab-tool-call-items
branch
from
760638f to
a4f6c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #31296 for the canonical-to-legacy event mappings.
Description
This PR makes the non-wait v1 collaboration tools—spawn, send input, resume, and close—emit canonical
TurnItem::CollabAgentToolCalllifecycle instead of their legacy begin/end events directly.App-server v2 consumes the canonical collab items directly, ignores the mapped legacy events, and applies close-agent thread-watch cleanup from the completed item.
Why
These four tools share the same single-target lifecycle shape. Wait stays separate because it carries multi-target status snapshots and has its own status-shaping cleanup.
What changed