chore(lint): enable unicorn/prefer-includes - #2130
Merged
HAYDEN-OAI merged 2 commits intoAug 7, 2026
Merged
Conversation
This was referenced Aug 7, 2026
jbeckwith-oai
approved these changes
Aug 7, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed exact head 48f7bf2. The includes conversions preserve behavior for the string and object-identity collections involved, and the added refs type makes the boundary clearer. Exact-head CI is green.
HAYDEN-OAI
added a commit
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/no-hex-escape` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 50; stacked on https://github.com/openai/openai-node. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack #2129 👈 this PR #2130 #2131 #2132 #2133 #2134 #2135 #2136 #2137 #2138 #2139 #2140 #2141
Base automatically changed from
dev/hayden/ultracite-050-unicorn-no-hex-escape
to
main
August 7, 2026 22:20
HAYDEN-OAI
enabled auto-merge
August 7, 2026 22:21
auto-merge was automatically disabled
August 7, 2026 22:23
Pull request was closed
Draft
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-dom-node-append` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 52; stacked on openai#2130. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 👈 this PR openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-dom-node-text-content` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 53; stacked on openai#2131. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 👈 this PR openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-regexp-test` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 54; stacked on openai#2132. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 👈 this PR openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-fallthrough` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 55; stacked on openai#2133. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 👈 this PR openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `yoda` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 56; stacked on openai#2134. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 👈 this PR openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-multi-assign` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 57; stacked on openai#2135. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 👈 this PR openai#2137 openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `jsdoc/require-yields` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 58; stacked on openai#2136. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 👈 this PR openai#2138 openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-class-fields` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 59; stacked on openai#2137. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 👈 this PR openai#2139 openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `typescript/unified-signatures` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 60; stacked on openai#2138. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 👈 this PR openai#2140 openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `guard-for-in` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 61; stacked on openai#2139. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` - `./scripts/build` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 👈 this PR openai#2141
euntaek-hong
pushed a commit
to wrongbutworks/openai-node
that referenced
this pull request
Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-new-wrappers` compatibility exception from `oxlint.config.ts`. - Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup. ## Additional context & links - Oxlint cleanup stack, part 62; stacked on openai#2140. - Preserves generated-file exclusions and repository-specific import policy. ### Validation - `pnpm lint` - `pnpm exec tsc --pretty false` - `pnpm exec vitest run --config vitest.config.mts --update=none` ## Stack openai#2129 openai#2130 openai#2131 openai#2132 openai#2133 openai#2134 openai#2135 openai#2136 openai#2137 openai#2138 openai#2139 openai#2140 openai#2141 👈 this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
unicorn/prefer-includescompatibility exception fromoxlint.config.ts.Additional context & links
Validation
pnpm lintpnpm exec tsc --pretty falsepnpm exec vitest run --config vitest.config.mts --update=noneStack
#2129
#2130 👈 this PR
#2131
#2132
#2133
#2134
#2135
#2136
#2137
#2138
#2139
#2140
#2141