Skip to content

chore(lint): enable unicorn/prefer-includes - #2130

Merged
HAYDEN-OAI merged 2 commits into
mainfrom
dev/hayden/ultracite-051-unicorn-prefer-includes
Aug 7, 2026
Merged

chore(lint): enable unicorn/prefer-includes#2130
HAYDEN-OAI merged 2 commits into
mainfrom
dev/hayden/ultracite-051-unicorn-prefer-includes

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the unicorn/prefer-includes compatibility exception from oxlint.config.ts.
  • Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2129
#2130 👈 this PR
#2131
#2132
#2133
#2134
#2135
#2136
#2137
#2138
#2139
#2140
#2141

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 48f7bf2. The includes conversions preserve behavior for the string and object-identity collections involved, and the added refs type makes the boundary clearer. Exact-head CI is green.

HAYDEN-OAI added a commit that referenced this pull request Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/no-hex-escape` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 50; stacked on
https://github.com/openai/openai-node.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

#2129 👈 this PR
#2130
#2131
#2132
#2133
#2134
#2135
#2136
#2137
#2138
#2139
#2140
#2141
Base automatically changed from dev/hayden/ultracite-050-unicorn-no-hex-escape to main August 7, 2026 22:20
@HAYDEN-OAI
HAYDEN-OAI enabled auto-merge August 7, 2026 22:21
@HAYDEN-OAI HAYDEN-OAI closed this Aug 7, 2026
auto-merge was automatically disabled August 7, 2026 22:23

Pull request was closed

@HAYDEN-OAI HAYDEN-OAI reopened this Aug 7, 2026
@openai-sdks

openai-sdks Bot commented Aug 7, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 10.108s for Node SDK PR #2130.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 140ms
tests/chat-completions-create.test.ts ✅ Passed 242ms
tests/chat-completions-stream.test.ts ✅ Passed 209ms
tests/files-content-binary.test.ts ✅ Passed 146ms
tests/files-create-multipart.test.ts ✅ Passed 146ms
tests/files-list-pagination.test.ts ✅ Passed 142ms
tests/initialize-config.test.ts ✅ Passed 170ms
tests/instance-isolation.test.ts ✅ Passed 92ms
tests/models-list.test.ts ✅ Passed 131ms
tests/responses-background-lifecycle.test.ts ✅ Passed 222ms
tests/responses-body-method-errors.test.ts ✅ Passed 338ms
tests/responses-cancel-timeout.test.ts ✅ Passed 217ms
tests/responses-cancel.test.ts ✅ Passed 223ms
tests/responses-compact-retries.test.ts ✅ Passed 231ms
tests/responses-compact.test.ts ✅ Passed 213ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 132ms
tests/responses-create-advanced.test.ts ✅ Passed 132ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.093s
tests/responses-create-errors.test.ts ✅ Passed 188ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 139ms
tests/responses-create-retries.test.ts ✅ Passed 299ms
tests/responses-create-stream-failures.test.ts ✅ Passed 185ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.15s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.557s
tests/responses-create-stream.test.ts ✅ Passed 66ms
tests/responses-create-terminal-states.test.ts ✅ Passed 206ms
tests/responses-create-timeout.test.ts ✅ Passed 193ms
tests/responses-create.test.ts ✅ Passed 183ms
tests/responses-delete.test.ts ✅ Passed 204ms
tests/responses-input-items-errors.test.ts ✅ Passed 257ms
tests/responses-input-items-list.test.ts ✅ Passed 177ms
tests/responses-input-items-options.test.ts ✅ Passed 111ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 222ms
tests/responses-input-tokens-count.test.ts ✅ Passed 218ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.168s
tests/responses-not-found-errors.test.ts ✅ Passed 247ms
tests/responses-parse.test.ts ✅ Passed 187ms
tests/responses-retrieve-retries.test.ts ✅ Passed 241ms
tests/responses-retrieve.test.ts ✅ Passed 212ms
tests/responses-stored-method-errors.test.ts ✅ Passed 524ms
tests/retry-behavior.test.ts ✅ Passed 2.921s
tests/sdk-error-shape.test.ts ✅ Passed 269ms

View OkTest run #31223668294

SDK merge (bebb8d3fccc1) · head (48f7bf2561f8) · base (d395852e9512) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 892eeaf Aug 7, 2026
40 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-051-unicorn-prefer-includes branch August 7, 2026 22:27
@openai-sdks openai-sdks Bot mentioned this pull request Aug 7, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-dom-node-append` compatibility exception
from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 52; stacked on
openai#2130.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131 👈 this PR
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-dom-node-text-content` compatibility
exception from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 53; stacked on
openai#2131.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132 👈 this PR
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-regexp-test` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 54; stacked on
openai#2132.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133 👈 this PR
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-fallthrough` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 55; stacked on
openai#2133.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134 👈 this PR
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `yoda` compatibility exception from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 56; stacked on
openai#2134.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135 👈 this PR
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-multi-assign` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 57; stacked on
openai#2135.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136 👈 this PR
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `jsdoc/require-yields` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 58; stacked on
openai#2136.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137 👈 this PR
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-class-fields` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 59; stacked on
openai#2137.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138 👈 this PR
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `typescript/unified-signatures` compatibility exception
from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 60; stacked on
openai#2138.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139 👈 this PR
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `guard-for-in` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 61; stacked on
openai#2139.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`
- `./scripts/build`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140 👈 this PR
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-new-wrappers` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 62; stacked on
openai#2140.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141 👈 this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants