Skip to content

chore(lint): enable typescript/unified-signatures - #2139

Merged
HAYDEN-OAI merged 12 commits into
mainfrom
dev/hayden/ultracite-060-typescript-unified-signatures
Aug 7, 2026
Merged

chore(lint): enable typescript/unified-signatures#2139
HAYDEN-OAI merged 12 commits into
mainfrom
dev/hayden/ultracite-060-typescript-unified-signatures

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the typescript/unified-signatures compatibility exception from oxlint.config.ts.
  • Resolve the 2 existing handwritten-code diagnostics with focused, behavior-preserving cleanup.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2129
#2130
#2131
#2132
#2133
#2134
#2135
#2136
#2137
#2138
#2139 👈 this PR
#2140
#2141

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head f92e883. Unifying the identical open/close listener overloads preserves the socket contract while making it more direct; the immediate stacked diff and CI are clean.

HAYDEN-OAI added a commit that referenced this pull request Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/no-hex-escape` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 50; stacked on
https://github.com/openai/openai-node.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

#2129 👈 this PR
#2130
#2131
#2132
#2133
#2134
#2135
#2136
#2137
#2138
#2139
#2140
#2141
@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-060-typescript-unified-signatures branch from f92e883 to c71223c Compare August 7, 2026 22:45
@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-059-unicorn-prefer-class-fields branch from b16baf3 to 1362967 Compare August 7, 2026 22:45
@openai-sdks

openai-sdks Bot commented Aug 7, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 9.241s for Node SDK PR #2139.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 122ms
tests/chat-completions-create.test.ts ✅ Passed 207ms
tests/chat-completions-stream.test.ts ✅ Passed 178ms
tests/files-content-binary.test.ts ✅ Passed 134ms
tests/files-create-multipart.test.ts ✅ Passed 128ms
tests/files-list-pagination.test.ts ✅ Passed 165ms
tests/initialize-config.test.ts ✅ Passed 268ms
tests/instance-isolation.test.ts ✅ Passed 87ms
tests/models-list.test.ts ✅ Passed 121ms
tests/responses-background-lifecycle.test.ts ✅ Passed 157ms
tests/responses-body-method-errors.test.ts ✅ Passed 248ms
tests/responses-cancel-timeout.test.ts ✅ Passed 205ms
tests/responses-cancel.test.ts ✅ Passed 321ms
tests/responses-compact-retries.test.ts ✅ Passed 190ms
tests/responses-compact.test.ts ✅ Passed 171ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 98ms
tests/responses-create-advanced.test.ts ✅ Passed 121ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.141s
tests/responses-create-errors.test.ts ✅ Passed 174ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 140ms
tests/responses-create-retries.test.ts ✅ Passed 277ms
tests/responses-create-stream-failures.test.ts ✅ Passed 160ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.141s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.099s
tests/responses-create-stream.test.ts ✅ Passed 73ms
tests/responses-create-terminal-states.test.ts ✅ Passed 170ms
tests/responses-create-timeout.test.ts ✅ Passed 262ms
tests/responses-create.test.ts ✅ Passed 167ms
tests/responses-delete.test.ts ✅ Passed 152ms
tests/responses-input-items-errors.test.ts ✅ Passed 176ms
tests/responses-input-items-list.test.ts ✅ Passed 149ms
tests/responses-input-items-options.test.ts ✅ Passed 83ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 248ms
tests/responses-input-tokens-count.test.ts ✅ Passed 225ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.743s
tests/responses-not-found-errors.test.ts ✅ Passed 222ms
tests/responses-parse.test.ts ✅ Passed 141ms
tests/responses-retrieve-retries.test.ts ✅ Passed 199ms
tests/responses-retrieve.test.ts ✅ Passed 173ms
tests/responses-stored-method-errors.test.ts ✅ Passed 533ms
tests/retry-behavior.test.ts ✅ Passed 2.928s
tests/sdk-error-shape.test.ts ✅ Passed 223ms

View OkTest run #31227336386

SDK merge (db329a430f8d) · head (91929676afda) · base (da7b9f58272c) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 4427bb5 Aug 7, 2026
47 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-060-typescript-unified-signatures branch August 7, 2026 23:34
@openai-sdks openai-sdks Bot mentioned this pull request Aug 7, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-includes` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 51; stacked on
openai#2129.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130 👈 this PR
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-dom-node-append` compatibility exception
from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 52; stacked on
openai#2130.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131 👈 this PR
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-dom-node-text-content` compatibility
exception from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 53; stacked on
openai#2131.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132 👈 this PR
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-regexp-test` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 54; stacked on
openai#2132.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133 👈 this PR
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-fallthrough` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 55; stacked on
openai#2133.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134 👈 this PR
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `yoda` compatibility exception from `oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 56; stacked on
openai#2134.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135 👈 this PR
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-multi-assign` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 57; stacked on
openai#2135.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136 👈 this PR
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `jsdoc/require-yields` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 58; stacked on
openai#2136.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137 👈 this PR
openai#2138
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-class-fields` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 59; stacked on
openai#2137.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138 👈 this PR
openai#2139
openai#2140
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `guard-for-in` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 61; stacked on
openai#2139.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`
- `./scripts/build`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140 👈 this PR
openai#2141
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-new-wrappers` compatibility exception from
`oxlint.config.ts`.
- Resolve the 2 existing handwritten-code diagnostics with focused,
behavior-preserving cleanup.

## Additional context & links

- Oxlint cleanup stack, part 62; stacked on
openai#2140.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2129
openai#2130
openai#2131
openai#2132
openai#2133
openai#2134
openai#2135
openai#2136
openai#2137
openai#2138
openai#2139
openai#2140
openai#2141 👈 this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants