chore(lint): enable unicorn/no-thenable - #2118
Merged
Merged
Conversation
edenbuilds
pushed a commit
to edenbuilds/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `jsdoc/require-returns-description` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 32; stacked on openai#2105. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 👈 this PR openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-extend-native` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 33; stacked on openai#2106. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 👈 this PR openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-loop-func` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 34; stacked on openai#2107. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 👈 this PR openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-unmodified-loop-condition` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 35; stacked on openai#2108. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 👈 this PR openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `prefer-regex-literals` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 36; stacked on openai#2109. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 👈 this PR openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `promise/prefer-catch` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 37; stacked on openai#2110. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 👈 this PR openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `typescript/no-empty-interface` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 38; stacked on openai#2111. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 👈 this PR openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `typescript/no-extraneous-class` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 39; stacked on openai#2112. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 👈 this PR openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `typescript/no-this-alias` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 40; stacked on openai#2113. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 👈 this PR openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
edenbuilds
pushed a commit
to edenbuilds/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/error-message` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 41; stacked on openai#2114. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 👈 this PR openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
Base automatically changed from
dev/hayden/ultracite-043-unicorn-no-object-as-default-parameter
to
main
August 7, 2026 19:30
Draft
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/no-immediate-mutation` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 42; stacked on openai#2115. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 👈 this PR openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/no-object-as-default-parameter` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 43; stacked on openai#2116. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 👈 this PR openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/no-this-assignment` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - No source changes are needed; existing handwritten files already satisfy the preset rule. ## Additional context & links - Oxlint cleanup stack, part 45; stacked on openai#2118. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Oxlint configuration regression tests. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 👈 this PR openai#2120 openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
…nai#2120) - [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-logical-operator-over-ternary` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 46; stacked on openai#2119. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 👈 this PR openai#2121 openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
…2121) - [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-native-coercion-functions` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 47; stacked on openai#2120. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 👈 this PR openai#2122 openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `unicorn/prefer-object-from-entries` compatibility exception from `oxlint.config.ts`. - Baseline: 1 handwritten-code violation on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 48; stacked on openai#2121. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 👈 this PR openai#2123
HAYDEN-OAI
added a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 7, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-sequences` compatibility exception from `oxlint.config.ts`. - Baseline: 2 handwritten-code violations on `main`. - Apply safe Ultracite autofixes and focused, behavior-preserving handwritten-code cleanup. ## Additional context & links - Oxlint cleanup stack, part 49; stacked on openai#2122. - Preserves Stainless-generated-file exclusions and repository-specific import policy. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Complete handwritten Vitest suite. ### Stack openai#2090 openai#2091 openai#2092 openai#2093 openai#2094 openai#2095 openai#2096 openai#2097 openai#2098 openai#2099 openai#2100 openai#2101 openai#2102 openai#2103 openai#2104 openai#2105 openai#2106 openai#2107 openai#2108 openai#2109 openai#2110 openai#2111 openai#2112 openai#2113 openai#2114 openai#2115 openai#2116 openai#2117 openai#2118 openai#2119 openai#2120 openai#2121 openai#2122 openai#2123 👈 this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
unicorn/no-thenablecompatibility exception fromoxlint.config.ts.main.Additional context & links
Validation
Stack
#2090
#2091
#2092
#2093
#2094
#2095
#2096
#2097
#2098
#2099
#2100
#2101
#2102
#2103
#2104
#2105
#2106
#2107
#2108
#2109
#2110
#2111
#2112
#2113
#2114
#2115
#2116
#2117
#2118 👈 this PR
#2119
#2120
#2121
#2122
#2123