Skip to content

feat: support $expand=children on the driveItem endpoint - #3445

Merged
butonic merged 5 commits into
mainfrom
feat/graph-expand-children
Sep 3, 2026
Merged

feat: support $expand=children on the driveItem endpoint#3445
butonic merged 5 commits into
mainfrom
feat/graph-expand-children

Conversation

@dschmidt

@dschmidt dschmidt commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Implements $expand=children on GET /v1.0|v1beta1/drives/{drive-id}/items/{item-id}, the server side of opencloud-eu/libre-graph-api#68.

A folder listing currently needs two requests against graph (stat the folder, then list its children), where a single WebDAV PROPFIND with Depth: 1 returns both at once. With $expand=children clients get back to one request.

The children come from the same code path as the /children endpoint: the listing was moved into listDriveItemChildren and both callers share it, so the items and the error responses are identical. $expand is parsed by a helper mirroring the existing $select one. The relation stays unset for anything that is not a container.

No SDK bump needed, children is already part of the vendored driveItem model.

@codacy-production

codacy-production Bot commented Sep 1, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 15 duplication

Metric Results
Duplication 15

View in Codacy

🟢 Coverage 88.57% diff coverage · +0.05% coverage variation

Metric Results
Coverage variation +0.05% coverage variation (-1.00%)
Diff coverage 88.57% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f60e2e5) 87708 20427 23.29%
Head commit (0750884) 87725 (+17) 20477 (+50) 23.34% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3445) 35 31 88.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@dschmidt
dschmidt marked this pull request as ready for review September 1, 2026 18:05
@dschmidt
dschmidt requested review from butonic and micbar September 1, 2026 18:06
@butonic
butonic merged commit 993265b into main Sep 3, 2026
66 of 67 checks passed
@butonic
butonic deleted the feat/graph-expand-children branch September 3, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants