Create a kube-controller-manager image that contains ceph-common

[smarterclayton]

Only kube-controller-manager needs access to these binaries. Makes the image 50M larger, probably bigger when we add the other dependencies.

[smarterclayton]

/retest

[smarterclayton]

@mfojtik still assessing the impact here. Talking with @gnufied and reaching out to the ceph team.

For attach/detach, apparently iscsi and others are needed in the controller manager image. @gnufied do you have the list?

[smarterclayton]

/retest

[gnufied]

@smarterclayton @mfojtik looks like ceph-common is the only package we need in controller-manager image. iscsi tools aren't needed in controller-manager.

The other thing is - flexvolume binaries in case users want to use flexvolume plugins that support attach/detach but we don't necessarily need to bake anything in the controller-manager image for that.

[smarterclayton]

/retest

[jsafrane]

/retest
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• images/OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eparis]

/hold
questions about ceph client tools in RHEL8 might change if we do this at all

[jsafrane]

questions about ceph client tools in RHEL8 might change if we do this at all

See https://bugzilla.redhat.com/show_bug.cgi?id=1665912 for details

[eparis]

/close
at this point we only expect to support ceph via CSI, not via flex or the built in driver. As such we do not plan to merge this PR.

[openshift-ci-robot]

@eparis: Closed this PR.

Details

In response to this:

/close
at this point we only expect to support ceph via CSI, not via flex or the built in driver. As such we do not plan to merge this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.