Skip to content

Build kube-proxy image#22155

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
pecameron:kube-proxy
Mar 26, 2019
Merged

Build kube-proxy image#22155
openshift-merge-robot merged 1 commit into
openshift:masterfrom
pecameron:kube-proxy

Conversation

@pecameron

@pecameron pecameron commented Feb 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This image is hyperkube with conntrack-tools and iptables

SDN-310 Create origin kube-proxy image
https://jira.coreos.com/browse/SDN-310

Signed-off-by: Phil Cameron pcameron@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2019
@pecameron

pecameron commented Feb 26, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton @sdodson @squeed PTAL

@smarterclayton

smarterclayton commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

/hold

Need the ART repo created, and then link to ocp-build-data. Also, you need to be built on top of my PR to ocp-build-data that reorders parents

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@smarterclayton

smarterclayton commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

Another related change #22082 but isn't in 4.0

@pecameron

pecameron commented Feb 26, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton Could you tell me more about "built on top of my PR to ocp-build-data that reorders parents"? How do I do this?

dcbw
dcbw reviewed Mar 11, 2019
View reviewed changes
Comment thread images/kube-proxy/OWNERS
@@ -0,0 +1,5 @@
reviewers:

@dcbw dcbw Mar 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pecameron could you add people from the net team to the image OWNERS too? As long as @smarterclayton thinks that's OK of course. To both Reviewers and Approvers.

@pecameron pecameron Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @dcbw @squeed PTAL

@pecameron
Build kube-proxy image
ae5cc6d 
This image is hyperkube with conntrack-tools and iptables

SDN-310 Create origin kube-proxy image
https://jira.coreos.com/browse/SDN-310

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@pecameron

pecameron commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton ci/prow/e2e-aws failed with
evel=fatal msg="waiting for Kubernetes API: context deadline exceeded"

@pecameron

pecameron commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@pecameron

pecameron commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@pecameron

pecameron commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@pecameron

pecameron commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

ci/prow/e2e-aws — Job succeeded.
next test run...
/test e2e-aws

@pecameron

pecameron commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

ci/prow/e2e-aws — Job succeeded.
rerun test
/test e2e-aws

@pecameron

pecameron commented Mar 14, 2019

Copy link
Copy Markdown
Contributor Author

Failed before network started
clusteroperator/kube-controller-manager changed Failing to True: StaticPodsFailing: StaticPodsFailing: nodes/ip-10-0-158-188.ec2.internal

/test e2e-aws

@pecameron

pecameron commented Mar 14, 2019

Copy link
Copy Markdown
Contributor Author

Failed: StaticPodsFailing: nodes/ip-10-0-158-188.ec2.internal
/test e2e-aws

@pecameron

pecameron commented Mar 14, 2019

Copy link
Copy Markdown
Contributor Author

Succeeded: 3
ci/prow/e2e-aws — Job succeeded.
/test e2e-aws

@pecameron

pecameron commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

Succeeded: 4
ci/prow/e2e-aws — Job succeeded.
/test e2e-aws

@pecameron

pecameron commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

Succeeded: 5
ci/prow/e2e-aws — Job succeeded.
/test e2e-aws

@pecameron

pecameron commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

Succeeded: 6
ci/prow/e2e-aws — Job succeeded.
/test e2e-aws

@pecameron

pecameron commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

Failed: kube-apiserver Kube API started failing
Succeeded: 6

/test e2e-aws

@pecameron

pecameron commented Mar 18, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton @dcbw what more needs to be done before this merges?
This is just hyperkube with 2 additional rpms that are not used in the image.

@dcbw

dcbw commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

/retest

@dcbw

dcbw commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@pecameron

pecameron commented Mar 18, 2019

Copy link
Copy Markdown
Contributor Author

/assign @sdodson

@pecameron

pecameron commented Mar 18, 2019

Copy link
Copy Markdown
Contributor Author

@sdodson PTAL

@sdodson

sdodson commented Mar 19, 2019

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot

openshift-ci-robot commented Mar 19, 2019

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, pecameron, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2019
@pecameron

pecameron commented Mar 19, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton @sdodson Can this be merged? Is there more to do?

@pecameron

pecameron commented Mar 20, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton Can this be merged now? It blocks ART-487.

1 similar comment
@pecameron

pecameron commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

@smarterclayton Can this be merged now? It blocks ART-487.

@sdodson

sdodson commented Mar 26, 2019

Copy link
Copy Markdown
Member

/hold cancel
The referenced ART-487 seems to address Clayton's concerns, please make sure that we follow through with everything required therein.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2019
@pecameron

pecameron commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

@sdodson I'm confused (again). I thought this PR had to go in to unblock ART-487. I thought @smarterclayton was holding off on the merge to let some other items happen first. As far as I know the kube-proxy image is supposed to be part of 4.1 (needed by Callico) and we are hard upon the date.
@knobunc this is the pr we discussed at lunch.

@openshift-merge-robot
openshift-merge-robot merged commit 89a6bcb into openshift:master Mar 26, 2019
@pecameron pecameron mentioned this pull request May 7, 2019
Merged
@pecameron
pecameron deleted the kube-proxy branch May 10, 2019 13:14
pecameron added a commit to pecameron/release that referenced this pull request Jun 3, 2019
@pecameron
SDN-310 - create origin-kube-proxy image
e23c7d6 
We already have ose-kube-proxy and need origin-kube-proxy as well.
The image is hyperkube with 2 additional rpms: iptables conntrack-tools
See: openshift/origin#22155

https://jira.coreos.com/browse/SDN-310

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@tmjd tmjd mentioned this pull request Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pweil- pweil- Awaiting requested review from pweil-
@sdodson sdodson Awaiting requested review from sdodson
1 more reviewer
@dcbw dcbw dcbw left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pecameron @smarterclayton @dcbw @sdodson @openshift-ci-robot @openshift-merge-robot