repo: Using hardcoded ARTIFACT_DIR instead of variable #15420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
smarterclayton
force-pushed
the
artifact_dir
branch
from
c6a87b8 to
979b63a
Compare
smarterclayton
changed the title
smarterclayton
force-pushed
the
artifact_dir
branch
from
979b63a to
90f699c
Compare
alvaroaleman
approved these changes
Feb 1, 2021
Contributor
alvaroaleman
left a comment
alvaroaleman
left a comment
There was a problem hiding this comment.
/hold
Unhold at your convenience
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
Enough units have passed that I think this pattern holds (ones with and without the mkdir, which failed elsewhere). /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
A common pattern was incorrect, resulting in jobs not running.
smarterclayton
force-pushed
the
artifact_dir
branch
from
90f699c to
ed27d45
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
Contributor
Contributor
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
@smarterclayton: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only change in master, 4.7, and 4.8 (and then come back and assess any issues backporting)