ROSAENG-60031 | ci: add optional govulncheck presubmit for openshift/rosa

[amandahla]

Summary

Add an optional Prow presubmit for openshift/rosa that runs make govulncheck in the src container.

Related

• Jira: ROSAENG-60031
• ROSA implementation: ROSAENG-60031 | ci: add govulncheck source and binary vulnerability scans rosa#3330 (merged)

Changes

• Add govulncheck test to ci-operator/config/openshift/rosa/openshift-rosa-master.yaml
• Regenerate ci-operator/jobs/openshift/rosa/openshift-rosa-master-presubmits.yaml via make jobs WHAT=openshift/rosa
• Run make ci-operator-config for determinized field ordering (optional after container)

Job behavior

• Context: ci/prow/govulncheck
• Trigger: /test govulncheck
• Optional: yes (does not block merge during rollout)
• Image: container: from: src (same OCP builder as lint)
• Commands: unset GOFLAGS + make govulncheck
• Skip: same skip_if_only_changed regex as lint/build/test/security

Validation

• make jobs WHAT=openshift/rosa
• make ci-operator-config (fixes ci-operator-config-metadata)
• CI ci/prow/config (checkconfig equivalent)
• CI ci/prow/ci-operator-config, generated-config, yamllint
• /pj-rehearse pull-ci-openshift-rosa-master-govulncheck (after merge)

Test plan

• Merge this PR
• On an openshift/rosa PR, run /test govulncheck
• Confirm job passes and reports source + binary scan results

[coderabbitai]

Warning

Review limit reached

@amandahla, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 666ecb68-0575-4a56-b7d8-107d89483c08

📥 Commits

Reviewing files that changed from the base of the PR and between 46e45d4 and 936b6d8.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/rosa/openshift-rosa-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/rosa/openshift-rosa-master.yaml

Walkthrough

This change adds a new optional govulncheck test step to the CI configuration for openshift-rosa-master, running make govulncheck in the src container with GOFLAGS unset and reusing the existing skip_if_only_changed filter.

Changes

CI govulncheck step

Layer / File(s)	Summary
Add govulncheck test step ci-operator/config/openshift/rosa/openshift-rosa-master.yaml	New optional test entry runs make govulncheck in the src container, unsets GOFLAGS, and reuses the existing skip_if_only_changed filter.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: davidleerh, gdbranco

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only ci-operator YAML changed; no Ginkgo tests or titles were added, so there are no dynamic test names to flag.
Test Structure And Quality	✅ Passed	PR only changes ci-operator YAML to add an optional govulncheck job; no Ginkgo test code or test logic was modified.
Microshift Test Compatibility	✅ Passed	Only ci-operator YAML changed; no new Ginkgo e2e tests or MicroShift-sensitive APIs/features were added, so the check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only ci-operator config changed; no Ginkgo/e2e test code was added, so there are no new SNO compatibility concerns.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a CI job stanza changed in ci-operator config; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	Only CI YAML changed; no process-level test binary code or stdout writes were introduced, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only ci-operator YAML changed; no new Ginkgo/e2e tests or networked test code were added.
No-Weak-Crypto	✅ Passed	Diff only updates ci-operator YAML to add a govulncheck presubmit; no weak-crypto APIs, custom crypto, or secret comparisons were introduced.
Container-Privileges	✅ Passed	The new govulncheck presubmit is a standard ci-operator job; no privileged, host*, SYS_ADMIN, or allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	The new govulncheck presubmit only runs unset GOFLAGS and make govulncheck; no added secrets, tokens, PII, or host/customer data are logged.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding an optional govulncheck presubmit for openshift/rosa.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@amandahla: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-rosa-master-govulncheck	openshift/rosa	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[amandahla]

/pj-rehearse pull-ci-openshift-rosa-master-govulncheck

[openshift-merge-bot]

@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[amandahla]

/hold

depends on openshift/rosa#3338

[amandahla]

/pj-rehearse pull-ci-openshift-rosa-master-govulncheck

[openshift-merge-bot]

@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@amandahla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[amandahla]

/unhold

[olucasfreitas]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/rosa/OWNERS [amandahla,olucasfreitas]
• ci-operator/jobs/openshift/rosa/OWNERS [amandahla,olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amandahla]

/pj-rehearse ack

[openshift-merge-bot]

@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.