ROSAENG-61450: wire rosa-clients for openshift/rosa CI#81830
Conversation
Depends on openshift/rosa#3366 (Dockerfile.clients + .ci-operator.yaml). Switch rosa ci-operator configs to build_root from_repository, run presubmits from rosa-clients, and regenerate prow jobs. Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
@amandahla: This pull request references ROSAENG-61450 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
WalkthroughROSA CI configurations now use repository-derived build roots. The main configuration defines a ChangesROSA CI image configuration
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 47 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@amandahla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Wire
openshift/rosaProw to a repo-ownedrosa-clientsimage (Dockerfile.clients) instead offrom: src/ hardcodedocp/builder.Blocked on / waits for: openshift/rosa#3366 (adds
Dockerfile.clientsand.ci-operator.yaml). Do not merge this until that PR is inopenshift/rosamaster.Changes
openshift-rosa-master.yaml:build_root: from_repository: true, buildDockerfile.clients→rosa-clients, point lint/build/test/commits/coverage/govulncheck atfrom: rosa-clientsbuild_root: from_repository: true(fixes e2e rhel-8 builder drift)/test images)Related
Test plan
/test images,/test build,/test lint,/test teston a rosa PR after mergeMade with Cursor
Summary by CodeRabbit
openshift/rosaCI configurations to build from the repository source.rosa-clientsimage fromDockerfile.clientsand uses it across build, test, lint, coverage, commit, and vulnerability checks./test images.openshift/rosa#3366, which providesDockerfile.clientsand.ci-operator.yaml.