MetalLB operator: add tls-scanner job - #82125
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oribon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe OpenShift CI configuration adds the ChangesMetalLB TLS scanner
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CI as tls-scanner test
participant Operator as operator-bundle install
participant MetalLB as MetalLB controller/speaker
participant FRR as openshift-frr-k8s
participant Scanner as generic-claim tls-scanner-run
CI->>Operator: Install bundle and wait for controller/webhook
CI->>MetalLB: Apply MetalLB custom resource and wait for controller/speaker
CI->>FRR: Wait for statuscleaner and daemonset
CI->>Scanner: Invoke tls-scanner-run
Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-main.yaml`:
- Around line 106-117: Remove the duplicate optional field from the tls-scanner
test mapping, retaining a single optional: true entry alongside the existing
cluster_claim and steps configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7eafc94e-3623-46f1-b6f0-0334ac1bc5e9
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/metallb-operator/openshift-metallb-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-main.yaml
| - always_run: false | ||
| as: tls-scanner | ||
| optional: true | ||
| cluster_claim: | ||
| architecture: amd64 | ||
| cloud: aws | ||
| owner: openshift-ci | ||
| product: ocp | ||
| timeout: 1h0m0s | ||
| version: "4.22" | ||
| optional: true | ||
| steps: |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Duplicate optional key in the same mapping.
optional: true is declared twice (Line 108 and Line 116) as sibling keys of the same tls-scanner test object. This is an invalid YAML mapping and is flagged by yamllint's key-duplicates check, which will likely fail CI validation/regeneration.
🐛 Proposed fix
version: "4.22"
- optional: true
steps:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - always_run: false | |
| as: tls-scanner | |
| optional: true | |
| cluster_claim: | |
| architecture: amd64 | |
| cloud: aws | |
| owner: openshift-ci | |
| product: ocp | |
| timeout: 1h0m0s | |
| version: "4.22" | |
| optional: true | |
| steps: | |
| - always_run: false | |
| as: tls-scanner | |
| optional: true | |
| cluster_claim: | |
| architecture: amd64 | |
| cloud: aws | |
| owner: openshift-ci | |
| product: ocp | |
| timeout: 1h0m0s | |
| version: "4.22" | |
| steps: |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 116-116: duplication of key "optional" in mapping
(key-duplicates)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-main.yaml`
around lines 106 - 117, Remove the duplicate optional field from the tls-scanner
test mapping, retaining a single optional: true entry alongside the existing
cluster_claim and steps configuration.
Source: Linters/SAST tools
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
12f76e4 to
f062cc8
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-metallb-operator-main-tls-scanner |
|
@oribon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@oribon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
Adds support in the OpenShift CI config for the MetalLB operator to run an optional
tls-scannerworkflow on AWS amd64 (OpenShift 4.22). The change provisions a newtls-scanner-toolbase image (tag5.0), then (when enabled) installs the MetalLB operator bundle, deploys aMetalLBcustom resource, waits for the MetalLB controller/speaker and theopenshift-frr-k8scomponents (frr-k8s-statuscleanerandfrr-k8sdaemonset) to become ready, and finally executes the scanner viageneric-claimusingref: tls-scanner-run.