Skip to content

Add Boskos leases for s390x virt VPN - #82263

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Davo911:ssp-s390x-boskos-leases
Aug 5, 2026
Merged

Add Boskos leases for s390x virt VPN#82263
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Davo911:ssp-s390x-boskos-leases

Conversation

@Davo911

@Davo911 Davo911 commented Jul 22, 2026

Copy link
Copy Markdown
Member

Follows the same pattern as #61638
Add Boskos quota slices for libvirt-s390x-vpn-ocp-virt (HA) and libvirt-s390x-vpn-ocp-virt-sno (SNO)

HA cluster profile already registered: openshift/ci-tools#5252

Summary by CodeRabbit

Adds new Boskos quota slices for the s390x virtual VPN cluster profiles:

  • HA (libvirt-s390x-vpn-ocp-virt): libvirt-s390x-vpn-virt-quota-slice with free leases libvirt-s390x-virt-0-0 and libvirt-s390x-virt-1-0
  • SNO (libvirt-s390x-vpn-ocp-virt-sno): libvirt-s390x-vpn-virt-sno-quota-slice with free leases libvirt-s390x-virt-sno-0-0 and libvirt-s390x-virt-sno-1-0

Updates core-services/prow/02_config/_boskos.yaml and extends core-services/prow/02_config/generate-boskos.py so the generator provisions the corresponding free lease entries for these OCP-virt instance slices.

@openshift-ci
openshift-ci Bot requested review from bear-redhat and pruan-rht July 22, 2026 01:30
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8b929e78-4a7b-4ace-82be-646ab0d98834

📥 Commits

Reviewing files that changed from the base of the PR and between b40907d and 4dbaa77.

📒 Files selected for processing (2)
  • core-services/prow/02_config/_boskos.yaml
  • core-services/prow/02_config/generate-boskos.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • core-services/prow/02_config/generate-boskos.py

Walkthrough

Adds generator definitions and Boskos resource declarations for libvirt s390x HA and SNO quota slices, covering two instances of each type with free state.

Changes

Libvirt s390x quota slices

Layer / File(s) Summary
Quota-slice generation
core-services/prow/02_config/generate-boskos.py
Defines HA and SNO quota-slice types and populates entries for two instance indexes.
Quota-slice resource declarations
core-services/prow/02_config/_boskos.yaml
Declares two resources for each quota-slice type, all marked free.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: pruan-rht, bear-redhat

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Boskos leases for s390x virt VPN resources.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only changes Boskos config generation and generated YAML.
Test Structure And Quality ✅ Passed PR only changes Boskos config generation/YAML; no Ginkgo tests or cluster-interaction code was added or modified.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; only Boskos config generation/data changed, so MicroShift API compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only Boskos config/generator changed; no new Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only Boskos quota-slice config/generator changed; no deployment manifests, operators, or controllers introducing scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed No process-level stdout writes were added; generate-boskos.py only writes _boskos.yaml and contains no print/sys.stdout/logging-to-stdout calls.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only Boskos config/YAML changed; no new or modified Ginkgo tests or network/IP code are present in the diff.
No-Weak-Crypto ✅ Passed Changed files only add Boskos resource names; no MD5/SHA1/DES/RC4/ECB/custom crypto or secret comparisons were found.
Container-Privileges ✅ Passed Changed files only add Boskos quota-slice config; no pod/container security fields like privileged, hostPID/network/ipc, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds Boskos quota-slice resource entries; no new log/print/logger usage or sensitive fields appear in the changed files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 22, 2026
Reserve HA and SNO lease slots for libvirt-s390x-vpn-ocp-virt
Signed-off-by: Thomas-David Griedel griedel911@gmail.com
@Davo911
Davo911 force-pushed the ssp-s390x-boskos-leases branch from b40907d to 4dbaa77 Compare July 22, 2026 01:38
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Davo911: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Davo911

Davo911 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

/cc @tvardema
/assign @tvardema

@openshift-ci
openshift-ci Bot requested a review from tvardema August 4, 2026 00:48
@Davo911

Davo911 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/assign @wking

@Davo911

Davo911 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/unassign @tvardema

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Davo911, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@Davo911: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 51a6705 into openshift:main Aug 5, 2026
13 checks passed
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@Davo911: Updated the resources configmap in namespace ci at cluster app.ci using the following files:

  • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml
Details

In response to this:

Follows the same pattern as #61638
Add Boskos quota slices for libvirt-s390x-vpn-ocp-virt (HA) and libvirt-s390x-vpn-ocp-virt-sno (SNO)

HA cluster profile already registered: openshift/ci-tools#5252

Summary by CodeRabbit

Adds new Boskos quota slices for the s390x virtual VPN cluster profiles:

  • HA (libvirt-s390x-vpn-ocp-virt): libvirt-s390x-vpn-virt-quota-slice with free leases libvirt-s390x-virt-0-0 and libvirt-s390x-virt-1-0
  • SNO (libvirt-s390x-vpn-ocp-virt-sno): libvirt-s390x-vpn-virt-sno-quota-slice with free leases libvirt-s390x-virt-sno-0-0 and libvirt-s390x-virt-sno-1-0

Updates core-services/prow/02_config/_boskos.yaml and extends core-services/prow/02_config/generate-boskos.py so the generator provisions the corresponding free lease entries for these OCP-virt instance slices.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants