Add Boskos leases for s390x virt VPN - #82263
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds generator definitions and Boskos resource declarations for libvirt s390x HA and SNO quota slices, covering two instances of each type with ChangesLibvirt s390x quota slices
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reserve HA and SNO lease slots for libvirt-s390x-vpn-ocp-virt Signed-off-by: Thomas-David Griedel griedel911@gmail.com
b40907d to
4dbaa77
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/assign @wking |
|
/unassign @tvardema |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Davo911, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Davo911: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Davo911: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Follows the same pattern as #61638
Add Boskos quota slices for
libvirt-s390x-vpn-ocp-virt(HA) andlibvirt-s390x-vpn-ocp-virt-sno(SNO)HA cluster profile already registered: openshift/ci-tools#5252
Summary by CodeRabbit
Adds new Boskos quota slices for the s390x virtual VPN cluster profiles:
libvirt-s390x-vpn-ocp-virt):libvirt-s390x-vpn-virt-quota-slicewith free leaseslibvirt-s390x-virt-0-0andlibvirt-s390x-virt-1-0libvirt-s390x-vpn-ocp-virt-sno):libvirt-s390x-vpn-virt-sno-quota-slicewith free leaseslibvirt-s390x-virt-sno-0-0andlibvirt-s390x-virt-sno-1-0Updates
core-services/prow/02_config/_boskos.yamland extendscore-services/prow/02_config/generate-boskos.pyso the generator provisions the corresponding free lease entries for these OCP-virt instance slices.