multiarch: add libvirt-s390x-vpn-hcp Boskos + secret bootstrap (1/2) - #83082
multiarch: add libvirt-s390x-vpn-hcp Boskos + secret bootstrap (1/2)#83082ibm-adarsh wants to merge 2 commits into
Conversation
Move lnxocp14 leases oz-3-2 and oz-3-3 from libvirt-s390x-vpn-oz into a dedicated HCP VPN profile so homogeneous OZ and HCP jobs do not share the same Boskos pool on that LPAR.
|
Hi @ibm-adarsh. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe change adds the Changeslibvirt-s390x HCP integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
/approve |
check-cluster-profiles-config requires cluster-secrets-libvirt-s390x-vpn-hcp to exist in the ci namespace before the profile can be registered. Keep Boskos and secret-bootstrap in this PR (1/2); register the profile in a follow-up after the secret is synced.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibm-adarsh, v78singh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test check-cluster-profiles-config |
|
@ibm-adarsh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Dependency (read first)
Companion PR (2/2): #83138
Merge order:
ci-secret-bootstrapforcluster-secrets-libvirt-s390x-vpn-hcpcluster-secrets-libvirt-s390x-vpn-hcpexists in thecinamespaceDo not merge #83138 before this PR and secret sync complete.
check-cluster-profiles-configrequires the live secret before profile registration (same split as #82161 + #82162).Summary
libvirt-s390x-oz-3-2andlibvirt-s390x-oz-3-3(lnxocp14) fromlibvirt-s390x-vpn-ozinto a newlibvirt-s390x-vpn-hcp-quota-sliceci-secret-bootstrapforcluster-secrets-libvirt-s390x-vpn-hcpHCP needs dedicated IPs on these 2 leases; leaving them in the shared OZ pool would let homogeneous jobs acquire them. Lease names are unchanged so existing CoreDNS rewrites for
libvirt-s390x-oz-3-*→ lnxocp14 still apply.Test plan
check-cluster-profiles-configpasses on this PRcluster-secrets-libvirt-s390x-vpn-hcpexists inci