ROSAENG-62357: Update CI for rosa-hyperfleet-api monorepo#82371
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@typeid: This pull request references ROSAENG-62357 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
typeid
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
WalkthroughThe CI workflow now builds and publishes separate ChangesROSA Hyperfleet multi-image CI flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CIJobs as CI jobs
participant ImagePush as rosa-hyperfleet-image-push
participant Quay
participant Provision as rosa-hyperfleet-provision
CIJobs->>ImagePush: Provide platform-api and hyperfleet-operator images
ImagePush->>Quay: Mirror primary and extra images
ImagePush->>Provision: Write component image override
Provision->>Provision: Generate and apply Helm overrides
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/rosa-hyperfleet/ephemeral-e2e/rosa-hyperfleet-ephemeral-e2e-workflow.yaml`:
- Line 22: Update the on-demand-e2e example configuration to document all
required multi-component inputs, including CI_COMPONENT_IMAGE,
CI_OPERATOR_IMAGE, and ROSA_REGIONAL_EXTRA_COMPONENTS, so it demonstrates the
operator override flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 17390362-f6d8-4a39-b595-ffcc5fc71bcc
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-hyperfleet-api/openshift-online-rosa-hyperfleet-api-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (6)
ci-operator/config/openshift-online/rosa-hyperfleet-api/openshift-online-rosa-hyperfleet-api-main.yamlci-operator/step-registry/rosa-hyperfleet/ephemeral-e2e/rosa-hyperfleet-ephemeral-e2e-workflow.yamlci-operator/step-registry/rosa-hyperfleet/image-push/rosa-hyperfleet-image-push-commands.shci-operator/step-registry/rosa-hyperfleet/image-push/rosa-hyperfleet-image-push-ref.yamlci-operator/step-registry/rosa-hyperfleet/provision/rosa-hyperfleet-provision-commands.shci-operator/step-registry/rosa-hyperfleet/provision/rosa-hyperfleet-provision-ref.yaml
| Usage from a CI config: | ||
| tests: | ||
| - as: rosa-regionality-compatibility-e2e | ||
| - as: on-demand-e2e |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document the second component dependency.
The example only supplies CI_COMPONENT_IMAGE; copying it will not provide CI_OPERATOR_IMAGE or ROSA_REGIONAL_EXTRA_COMPONENTS, so the new operator override flow is omitted. Update the example to show the multi-component inputs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/rosa-hyperfleet/ephemeral-e2e/rosa-hyperfleet-ephemeral-e2e-workflow.yaml`
at line 22, Update the on-demand-e2e example configuration to document all
required multi-component inputs, including CI_COMPONENT_IMAGE,
CI_OPERATOR_IMAGE, and ROSA_REGIONAL_EXTRA_COMPONENTS, so it demonstrates the
operator override flow.
Update CI config, image push, and ephemeral e2e workflow to support the consolidated monorepo structure with separate platform-api and hyperfleet-operator images. Adds multi-component image push and helm override support. Add integration test job with nested_podman capability for tests that need to run Postgres/DynamoDB containers via podman. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@typeid: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
platform-api(fromplatform-api/Dockerfile) andhyperfleet-operator(fromhyperfleet-operator/Dockerfile)rosa-regionality-compatibility-e2etoon-demand-e2eintegrationtest job withnested_podmancapability for tests that spin up Postgres/DynamoDB containers via podmanTest plan
/test on-demand-e2etriggers ephemeral e2e with both component images🤖 Generated with Claude Code
Summary by CodeRabbit
Updates the
rosa-hyperfleet-apiOpenShift CI configuration to build and publish separateplatform-apiandhyperfleet-operatorimages. Adds postsubmit pushes, nested-Podman integration testing, and renames the ephemeral e2e workflow toon-demand-e2e.Extends image-push and provisioning steps to support multiple component images, including per-component Quay destinations and Helm repository/tag overrides for ephemeral environments.