Skip to content

ROSAENG-62536: rosa-hyperfleet-api: promote CI image to ci namespace#82419

Open
rrp-bot wants to merge 2 commits into
openshift:mainfrom
rrp-bot:add-rosa-hyperfleet-api-ci-promotion
Open

ROSAENG-62536: rosa-hyperfleet-api: promote CI image to ci namespace#82419
rrp-bot wants to merge 2 commits into
openshift:mainfrom
rrp-bot:add-rosa-hyperfleet-api-ci-promotion

Conversation

@rrp-bot

@rrp-bot rrp-bot commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • Adds rosa-hyperfleet-api-ci image (built from ci/Containerfile) to the images block
  • Adds a promotion block to publish rosa-hyperfleet-api-ci to registry.ci.openshift.org/ci/rosa-hyperfleet-api-ci:latest
  • Excludes rosa-regional-platform-api from CI namespace promotion (it is handled separately by the existing push-image postsubmit)

Why

This is the first step towards switching build_root from project_image (which runs a full Docker build on every PR, taking ~15 minutes) to from_repository: true. That switch requires the CI image to be pre-promoted and stable in the CI registry before it can be referenced via .ci-operator.yaml in the repo.

Next steps

Once this merges and the first postsubmit promotes rosa-hyperfleet-api-ci:latest, a follow-up PR will:

  1. Switch build_root to from_repository: true + use_build_cache: true
  2. Add .ci-operator.yaml to the rosa-hyperfleet-api repo pointing at ci/rosa-hyperfleet-api-ci:latest

Summary by CodeRabbit

  • Adds the rosa-hyperfleet-api-ci image to the OpenShift Online ROSA Hyperfleet API CI configuration.
  • Promotes it as registry.ci.openshift.org/ci/rosa-hyperfleet-api-ci:latest.
  • Keeps rosa-regional-platform-api excluded because it is promoted separately by the existing postsubmit job.
  • Prepares future repository-based builds with caching.

Add rosa-hyperfleet-api-ci image (built from ci/Containerfile) and a
promotion block to publish it to the ci namespace. This is the first
step towards switching build_root to from_repository, which requires
the CI image to be pre-promoted before the switch can be made safely.
@psav

psav commented Jul 24, 2026

Copy link
Copy Markdown

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 24, 2026
@rrp-bot rrp-bot changed the title rosa-hyperfleet-api: promote CI image to ci namespace ROSAENG-62536: rosa-hyperfleet-api: promote CI image to ci namespace Jul 24, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@rrp-bot: This pull request references ROSAENG-62536 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds rosa-hyperfleet-api-ci image (built from ci/Containerfile) to the images block
  • Adds a promotion block to publish rosa-hyperfleet-api-ci to registry.ci.openshift.org/ci/rosa-hyperfleet-api-ci:latest
  • Excludes rosa-regional-platform-api from CI namespace promotion (it is handled separately by the existing push-image postsubmit)

Why

This is the first step towards switching build_root from project_image (which runs a full Docker build on every PR, taking ~15 minutes) to from_repository: true. That switch requires the CI image to be pre-promoted and stable in the CI registry before it can be referenced via .ci-operator.yaml in the repo.

Next steps

Once this merges and the first postsubmit promotes rosa-hyperfleet-api-ci:latest, a follow-up PR will:

  1. Switch build_root to from_repository: true + use_build_cache: true
  2. Add .ci-operator.yaml to the rosa-hyperfleet-api repo pointing at ci/rosa-hyperfleet-api-ci:latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@typeid typeid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@rrp-bot rrp-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-online/rosa-hyperfleet-api/openshift-online-rosa-hyperfleet-api-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-online/rosa-hyperfleet-api/openshift-online-rosa-hyperfleet-api-main-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b8bd55b3-c423-45cb-b091-8314e4a8ad5d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The ROSA Hyperfleet API CI configuration adds explicit Dockerfile-to-repository mappings and updates image promotion to the ci namespace using the latest tag, excluding rosa-regional-platform-api.

Changes

ROSA Hyperfleet image promotion

Layer / File(s) Summary
Image output mappings
ci-operator/config/openshift-online/rosa-hyperfleet-api/...
Defines build targets for rosa-hyperfleet-api-ci and rosa-regional-platform-api with explicit Dockerfile paths.
Promotion settings
ci-operator/config/openshift-online/rosa-hyperfleet-api/...
Promotes images to the ci namespace with the latest tag and excludes rosa-regional-platform-api.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: typeid

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: promoting the rosa-hyperfleet-api CI image to the ci namespace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes only ci-operator YAML; no Ginkgo tests or titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes a ci-operator YAML config; no Ginkgo test code was added or modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML changed; no new Ginkgo e2e tests or MicroShift-sensitive APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes a ci-operator YAML image/promotion config; no Ginkgo tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only a ci-operator config file changed; it adds image/promotion entries and no deployment or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML changed; no Go/test entrypoints or stdout-writing process code was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator YAML changed; no new Ginkgo e2e tests or networking code were added, so the IPv6/disconnected test check is not applicable.
No-Weak-Crypto ✅ Passed The PR only changes CI YAML; exact searches of the diff and file found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or crypto implementation code.
Container-Privileges ✅ Passed Only ci-operator image/promotion config changed; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/root settings found.
No-Sensitive-Data-In-Logs ✅ Passed The PR only updates a ci-operator YAML config; it adds image/promotion entries and contains no log statements or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Hi @rrp-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@openshift-ci
openshift-ci Bot requested review from Makdaam and cdoan1 July 24, 2026 16:25
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@psav

psav commented Jul 24, 2026

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psav, rrp-bot, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rrp-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-hyperfleet-api-main-images openshift-online/rosa-hyperfleet-api presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-hyperfleet-api-main-lint openshift-online/rosa-hyperfleet-api presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-hyperfleet-api-main-rosa-regionality-compatibility-e2e openshift-online/rosa-hyperfleet-api presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-hyperfleet-api-main-unit openshift-online/rosa-hyperfleet-api presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-hyperfleet-api-main-verify openshift-online/rosa-hyperfleet-api presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@psav

psav commented Jul 24, 2026

Copy link
Copy Markdown

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@psav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@psav

psav commented Jul 25, 2026

Copy link
Copy Markdown

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@psav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@rrp-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-online/rosa-hyperfleet-api/main/unit 926f0ed link unknown /pj-rehearse pull-ci-openshift-online-rosa-hyperfleet-api-main-unit
ci/rehearse/openshift-online/rosa-hyperfleet-api/main/lint 926f0ed link unknown /pj-rehearse pull-ci-openshift-online-rosa-hyperfleet-api-main-lint
ci/rehearse/openshift-online/rosa-hyperfleet-api/main/rosa-regionality-compatibility-e2e 926f0ed link unknown /pj-rehearse pull-ci-openshift-online-rosa-hyperfleet-api-main-rosa-regionality-compatibility-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants