INTEROP-9280: Add CR reporting to OPP 4.22 interop jobs - #82839
Conversation
Add mpiit-data-router-reporter step, DR__RP__CR_COMP_NAME, and MAP_TESTS to both interop-opp-aws and interop-opp-vsphere tests. Activate crons (AWS: 3x daily, vSphere: daily). Tracked by: INTEROP-9280 | Epic: INTEROP-9202
|
@amp-rh: This pull request references INTEROP-9280 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Warning Review limit reached
Next review available in: 49 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe policy collection configuration updates AWS and vSphere OPP schedules, adds test and reporting environment variables, and expands post-test actions. ChangesOPP schedule and reporting
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test all |
|
/auto-cc |
CI Configuration Review —
|
| Job | Before | After | Frequency change |
|---|---|---|---|
| AWS | 0 23 31 2 * (never — Feb 31 doesn't exist) |
0 6,14,22 * * * |
Never → 3× daily |
| vSphere | 0 0 1,15 * * |
0 6 * * * |
Bimonthly → daily |
The AWS job is being activated from a "parked" state to 3× daily. That's ~21 AWS cluster provisions per week, each running a large OPP interop suite with 6 compute nodes of type m6a.2xlarge. Make sure the aws-cspi-qe cluster profile quota can sustain this frequency, especially with potential overlapping runs at the 8-hour interval.
The vSphere job is moving from 2×/month to daily on vsphere02. This is a ~15× frequency increase — confirm vSphere resource capacity and lease availability.
3. AWS vs vSphere post chain parity
The AWS post chain includes acm-inspector and acm-tests-clc-destroy, which the vSphere post chain does not. This appears intentional since the vSphere test steps don't include acm-tests-clc-create (so no destroy is needed) and may not use the inspector. Just flagging for awareness.
ℹ️ Minor Notes
- The
mpiit-data-router-reporterstep uses imagedno/droute:latestwith a 30-minute timeout and credentials fromtest-credentials/mpiit-dr-creds. Ensure the secret is available onbuild03(AWS job cluster) andvsphere02(vSphere job cluster). - Consider whether the
pre:chain for vSphere also needs review since you're now partially overriding the workflow. Currently onlypost:is overridden —pre:andworkflow:coexist correctly for the pre/test phases.
Overall, the changes are well-structured and follow step registry best practices. The main item to double-check is whether dropping acm-common-post-execute from the vSphere post chain is intentional.
Review performed by Chai Bot (automated CI config review).
AI-generated. Review for accuracy.
|
/pj-rehearse ack |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse unack |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@amp-rh: job(s): unack either don't exist or were not found to be affected, and cannot be rehearsed |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Looks good after the cron fix in 53684d3.
Ready for rehearsals and merge. 👍 AI-generated. Review for accuracy. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amp-rh, jan-law The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@amiskin94: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
9da5789
into
openshift:main
Add mpiit-data-router-reporter step, DR__RP__CR_COMP_NAME, and MAP_TESTS to both interop-opp-aws and interop-opp-vsphere tests. Activate crons (AWS: 3x daily, vSphere: daily).
Tracked by: INTEROP-9280 | Epic: INTEROP-9202
Summary by CodeRabbit
mpiit-data-router-reporter.DR__RP__CR_COMP_NAMEandMAP_TESTSfor test mapping and reporting.