Skip to content

INTEROP-9280: Add CR reporting to OPP 4.22 interop jobs - #82839

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:interop-9280-opp-cr-reporting
Aug 5, 2026
Merged

INTEROP-9280: Add CR reporting to OPP 4.22 interop jobs#82839
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:interop-9280-opp-cr-reporting

Conversation

@amp-rh

@amp-rh amp-rh commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Add mpiit-data-router-reporter step, DR__RP__CR_COMP_NAME, and MAP_TESTS to both interop-opp-aws and interop-opp-vsphere tests. Activate crons (AWS: 3x daily, vSphere: daily).

Tracked by: INTEROP-9280 | Epic: INTEROP-9202

Summary by CodeRabbit

  • Updates the OPP 4.22 AWS and vSphere interop jobs in the policy-collection CI configuration.
  • Enables scheduled runs for AWS three times per day and vSphere once per day.
  • Adds CR reporting through mpiit-data-router-reporter.
  • Sets DR__RP__CR_COMP_NAME and MAP_TESTS for test mapping and reporting.
  • Extends vSphere post-steps with must-gather, deprovisioning, data-router reporting, and firewatch reporting.

Add mpiit-data-router-reporter step, DR__RP__CR_COMP_NAME, and MAP_TESTS
to both interop-opp-aws and interop-opp-vsphere tests. Activate crons
(AWS: 3x daily, vSphere: daily).

Tracked by: INTEROP-9280 | Epic: INTEROP-9202
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@amp-rh: This pull request references INTEROP-9280 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add mpiit-data-router-reporter step, DR__RP__CR_COMP_NAME, and MAP_TESTS to both interop-opp-aws and interop-opp-vsphere tests. Activate crons (AWS: 3x daily, vSphere: daily).

Tracked by: INTEROP-9280 | Epic: INTEROP-9202

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@redhat-chai-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f911fee3-b5ce-41eb-bd32-f76511023210

📥 Commits

Reviewing files that changed from the base of the PR and between 1783246 and 53684d3.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/stolostron/policy-collection/stolostron-policy-collection-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp4.22.yaml

Walkthrough

The policy collection configuration updates AWS and vSphere OPP schedules, adds test and reporting environment variables, and expands post-test actions.

Changes

OPP schedule and reporting

Layer / File(s) Summary
AWS OPP job configuration
ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp4.22.yaml
The AWS job runs at 06:00, 14:00, and 22:00 daily. It adds OPP, Firewatch, Jira, failure-handling, secondary-policy, and test-mapping variables. It also adds the mpiit-data-router-reporter post-step.
vSphere OPP job configuration
ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp4.22.yaml
The vSphere job runs daily at 06:00. It adds corresponding test variables and post-steps for operator collection, must-gather, cleanup, data-router reporting, and Firewatch reporting.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only CI YAML schedules, environment variables, and post-steps; it adds no Ginkgo test titles or dynamic values to test names.
Test Structure And Quality ✅ Passed The pull request changes only two YAML CI configuration files; it adds schedules, environment variables, and post-steps, with no Ginkgo test code to assess.
Microshift Test Compatibility ✅ Passed The patch changes only CI YAML schedules, environment variables, and post-steps; it adds no Ginkgo e2e tests that require MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only CI YAML configuration files; added lines contain schedules, environment variables, and post-step references, with no new Ginkgo tests or SNO-sensitive assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI job YAML, cron schedules, environment variables, and post-step references; it adds no deployment manifests, controllers, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only CI YAML and generated job configuration; it adds no OTE binary source or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only CI YAML and generated periodic jobs; it adds no Ginkgo tests or IPv4/network code. Existing GitHub URL lines are unchanged.
No-Weak-Crypto ✅ Passed The commit adds schedules, environment variables, and reporter steps only; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons appear in added lines.
Container-Privileges ✅ Passed The PR changes only cron values, environment variables, and step references; no changed manifest contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds schedules, metadata, and standard reporter references only; no passwords, tokens, PII, customer data, or logging statements are added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding CR reporting to the OPP 4.22 interop jobs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amiskin94

Copy link
Copy Markdown
Contributor

/test all

@amiskin94

Copy link
Copy Markdown
Contributor

/auto-cc

@openshift-ci
openshift-ci Bot requested review from dhaiducek and gparvin August 5, 2026 06:35

@jan-law jan-law left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2026

@jan-law jan-law left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@amp-rh
amp-rh marked this pull request as ready for review August 5, 2026 16:21
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
@redhat-chai-bot

Copy link
Copy Markdown
Contributor

CI Configuration Review — INTEROP-9280

I reviewed the ci-operator config and generated prowjob changes. Here are my findings:


✅ Looks Good

Step ordering: The mpiit-data-router-reporter step is correctly positioned in both jobs — after cluster teardown/must-gather but before firewatch-report-issues. This ensures test results are routed to Report Portal before Firewatch creates Jira issues, which is the correct ordering for the reporting pipeline.

Environment variables: DR__RP__CR_COMP_NAME: lp-interop--OPP is the correct variable consumed by mpiit-data-router-reporter for Component Readiness launch naming. MAP_TESTS: "true" enables test mapping as expected.

Generated prowjob file: The cron updates in stolostron-policy-collection-main-periodics.yaml correctly mirror the ci-operator config source of truth.

allow_best_effort_post_steps: true: Already set on both jobs, which is important — it ensures that if an earlier post step fails, the data-router-reporter and firewatch steps still execute.


⚠️ Items to Verify

1. vSphere post: override drops acm-common-post-execute

The interop-opp-vsphere test uses workflow: acm-ipi-vsphere. That workflow's default post chain is:

post:
- chain: ipi-vsphere-post     # gather-core-dump, gather-network, gather-vsphere, ipi-deprovision-vsphere
- ref: acm-common-post-execute # ACM-specific post-test cleanup/reporting

Adding an explicit post: block in the ci-operator config overrides the workflow's post chain entirely. The new explicit post includes ipi-vsphere-post (good) but omits acm-common-post-execute.

Is this intentional? The acm-common-post-execute step performs common ACM post-test steps. If those are no longer needed (perhaps superseded by the new data router flow), this is fine — but it's worth confirming.

2. Significant cron schedule changes

Job Before After Frequency change
AWS 0 23 31 2 * (never — Feb 31 doesn't exist) 0 6,14,22 * * * Never → 3× daily
vSphere 0 0 1,15 * * 0 6 * * * Bimonthly → daily

The AWS job is being activated from a "parked" state to 3× daily. That's ~21 AWS cluster provisions per week, each running a large OPP interop suite with 6 compute nodes of type m6a.2xlarge. Make sure the aws-cspi-qe cluster profile quota can sustain this frequency, especially with potential overlapping runs at the 8-hour interval.

The vSphere job is moving from 2×/month to daily on vsphere02. This is a ~15× frequency increase — confirm vSphere resource capacity and lease availability.

3. AWS vs vSphere post chain parity

The AWS post chain includes acm-inspector and acm-tests-clc-destroy, which the vSphere post chain does not. This appears intentional since the vSphere test steps don't include acm-tests-clc-create (so no destroy is needed) and may not use the inspector. Just flagging for awareness.


ℹ️ Minor Notes

  • The mpiit-data-router-reporter step uses image dno/droute:latest with a 30-minute timeout and credentials from test-credentials/mpiit-dr-creds. Ensure the secret is available on build03 (AWS job cluster) and vsphere02 (vSphere job cluster).
  • Consider whether the pre: chain for vSphere also needs review since you're now partially overriding the workflow. Currently only post: is overridden — pre: and workflow: coexist correctly for the pre/test phases.

Overall, the changes are well-structured and follow step registry best practices. The main item to double-check is whether dropping acm-common-post-execute from the vSphere post chain is intentional.

Review performed by Chai Bot (automated CI config review).


AI-generated. Review for accuracy.

@amp-rh

amp-rh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 5, 2026
@amp-rh

amp-rh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse unack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amp-rh: job(s): unack either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 5, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@amp-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-stolostron-policy-collection-main-ocp4.22-interop-opp-aws N/A periodic Ci-operator config changed
periodic-ci-stolostron-policy-collection-main-ocp4.22-interop-opp-vsphere N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@redhat-chai-bot

redhat-chai-bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Looks good after the cron fix in 53684d3.

  • Both cron schedules are now 0 3,15 * * *, which matches the CR standard of ≥7 runs/week (per TRT-1877 rationale).
  • The explicit vSphere post chain is intentional — standard OPP interop pattern, no steps dropped.

Ready for rehearsals and merge. 👍


AI-generated. Review for accuracy.

@jan-law

jan-law commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amp-rh, jan-law

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amiskin94

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amiskin94: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 9da5789 into openshift:main Aug 5, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants