INTEROP-9402: Add MAP_TESTS support to Quay and ACM step refs - #82881
Conversation
Enable Component Readiness junit suite name remapping for the OPP multi-LP job by adding MAP_TESTS and DR__RP__CR_COMP_NAME env vars to the Quay interop test ref and three ACM test refs (observability, grc, alc). When MAP_TESTS=true, each ref sources ExitTrap--PostProcessPrep to rename junit suites for CR routing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@amiskin94: This pull request references INTEROP-9402 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@amiskin94, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughACM and Quay test steps add ChangesMapped test processing
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant TestStep
participant WgetOrCurl
participant ExitTrapPostProcessPrep
participant ArtifactStorage
TestStep->>WgetOrCurl: Download shared helper when MAP_TESTS is true
WgetOrCurl-->>TestStep: Return helper script
TestStep->>ExitTrapPostProcessPrep: Register component-specific EXIT trap
TestStep->>ArtifactStorage: Copy test artifacts
ExitTrapPostProcessPrep-->>TestStep: Process mapped test results and artifacts on exit
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The CI registry requires grace_period when a script uses trap commands, so the EXIT handler has time to run before the pod is killed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/acm/tests/alc/acm-tests-alc-commands.sh`:
- Around line 7-15: Replace the direct eval-based helper acquisition before the
ExitTrap--PostProcessPrep trap in
ci-operator/step-registry/acm/tests/alc/acm-tests-alc-commands.sh lines 7-15,
ci-operator/step-registry/acm/tests/grc/acm-tests-grc-commands.sh lines 7-15,
ci-operator/step-registry/acm/tests/observability/acm-tests-observability-commands.sh
lines 5-13, and
ci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-commands.sh
lines 40-49 with a temporary-file download using bounded connection and total
timeouts plus retry settings; verify the download succeeds before
sourcing/evaluating it and registering the EXIT trap.
- Around line 7-15: Replace the mutable main-branch downloads executed by eval
in ci-operator/step-registry/acm/tests/alc/acm-tests-alc-commands.sh:7-15,
ci-operator/step-registry/acm/tests/grc/acm-tests-grc-commands.sh:7-15,
ci-operator/step-registry/acm/tests/observability/acm-tests-observability-commands.sh:5-13,
and
ci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-commands.sh:40-49
with a repository-controlled helper or an immutable commit fetch. Verify the
downloaded content against a checked-in digest before sourcing or executing it,
while preserving the existing ExitTrap--PostProcessPrep setup and trap behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 39a632b1-c692-4b6b-bc5f-f1c0bf5154fc
📒 Files selected for processing (8)
ci-operator/step-registry/acm/tests/alc/acm-tests-alc-commands.shci-operator/step-registry/acm/tests/alc/acm-tests-alc-ref.yamlci-operator/step-registry/acm/tests/grc/acm-tests-grc-commands.shci-operator/step-registry/acm/tests/grc/acm-tests-grc-ref.yamlci-operator/step-registry/acm/tests/observability/acm-tests-observability-commands.shci-operator/step-registry/acm/tests/observability/acm-tests-observability-ref.yamlci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-commands.shci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-ref.yaml
Addresses CodeRabbit review feedback: adds --connect-timeout/--max-time (curl) and --timeout (wget) to bound the ExitTrap--PostProcessPrep download, and validates the function exists before installing the EXIT trap — gracefully degrading if the download fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amiskin94: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amiskin94, jbpratt, vboulos The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@amiskin94: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
4 participants
Summary
MAP_TESTSandDR__RP__CR_COMP_NAMEenv vars to 4 step refs used by the OPP multi-LP job, enabling Component Readiness junit suite name remapping viaExitTrap--PostProcessPrepquay-tests-quay-interop-test— MAP_TESTS block chained with existingcopyArtifactsEXIT trapacm-tests-observability,acm-tests-grc,acm-tests-alc— MAP_TESTS block added at script topDetails
When
MAP_TESTS=true(set at job level by PR #82839), each ref downloads and sourcesExitTrap--PostProcessPrep.shto rename junit test suite names to${DR__RP__CR_COMP_NAME}--%s. Theci-test-mappingSuiteRegEx patterns (PR #799) then route these to per-product CR components.Defaults (
MAP_TESTS=false) preserve existing behavior — no functional change unless explicitly enabled.Related
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
MAP_TESTS=true, each step downloads and loadsExitTrap--PostProcessPrep.shwithwgetorcurl, using download timeouts.DR__RP__CR_COMP_NAMEfor component-based result routing.MAP_TESTS=false.