feat(aro-hcp): add ARM helper Boskos pool

[roivaz]

https://redhat.atlassian.net/browse/AROSLSRE-1679

Why

Azure/ARO-HCP#6376 has created a 40-member DEV ARM-helper identity pool, but Boskos does not yet know about those resources. The inventory must roll out independently before #82980 can request two identities and rehearse the affected jobs.

What

• Add the aro-hcp-arm-helper-sp-dev Boskos resource type.
• Add 40 transparent resources named aro-hcp-arm-helper-sp-dev-0 through aro-hcp-arm-helper-sp-dev-39.
• Regenerate _boskos.yaml from generate-boskos.py.

The job lease declarations and provisioning behavior remain scoped to #82980.

Testing

• make boskos-config
• make check-boskos
• git diff --check

Summary by CodeRabbit

• Adds 40 transparent Boskos resources for the aro-hcp-arm-helper-sp-dev resource type.
• Regenerates the Boskos inventory so the resources are available for future CI job lease and provisioning changes.
• Validates the configuration with make boskos-config, make check-boskos, and git diff --check.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ecc74bc8-5cfe-4e84-baf6-b9bc897d0e94

📥 Commits

Reviewing files that changed from the base of the PR and between f518d40 and e284903.

📒 Files selected for processing (2)

• core-services/prow/02_config/_boskos.yaml
• core-services/prow/02_config/generate-boskos.py

---

Walkthrough

The Boskos configuration adds the aro-hcp-arm-helper-sp-dev quota slice and defines 40 named resources. The generator creates one resource for each slot, and the YAML declares all slots as initially free.

Changes

ARO HCP ARM helper resources

Layer / File(s)	Summary
Define and generate helper resources core-services/prow/02_config/generate-boskos.py, core-services/prow/02_config/_boskos.yaml	The generator adds the aro-hcp-arm-helper-sp-dev quota slice and creates 40 resources. The Boskos YAML declares resources -0 through -39 with free state.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: davo911, amisstea

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the addition of the ARM helper Boskos resource pool.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only Boskos YAML and its Python generator; no Ginkgo test files or test-title constructs are added or modified.
Test Structure And Quality	✅ Passed	The PR changes only Boskos YAML and its Python generator; no Ginkgo tests, cluster operations, It blocks, or Eventually/Consistently calls are present.
Microshift Test Compatibility	✅ Passed	The pull request changes only Boskos YAML and Python configuration; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only Boskos YAML and a Python generator; no new Ginkgo tests or multi-node test assumptions are present.
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only Boskos YAML and its Python generator; they add resource names and quota data, with no deployment, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only Boskos YAML and a Python generator; no OTE Go binary, main/suite setup, or process-level stdout write is changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch changes only Boskos YAML and its Python generator; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR adds only Boskos resource names, free state, and Python inventory generation; the exact diff contains no weak-crypto APIs, algorithms, comparisons, or custom crypto.
Container-Privileges	✅ Passed	The commit changes only Boskos inventory YAML and its Python generator; added lines contain no container/Kubernetes privilege fields or root settings.
No-Sensitive-Data-In-Logs	✅ Passed	The commit only adds Boskos resource identifiers and generator entries; no logging calls or sensitive values appear in the added lines.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[roivaz]

@wking, could you please review this standalone Boskos inventory addition? core-services/prow/02_config/OWNERS lists you as the file-specific approver for generate-boskos.py and _boskos.yaml.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@roivaz: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

@roivaz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prucek, roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/OWNERS [Prucek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@roivaz: Updated the resources configmap in namespace ci at cluster app.ci using the following files:

• key boskos.yaml using file core-services/prow/02_config/_boskos.yaml

Details

In response to this:

https://redhat.atlassian.net/browse/AROSLSRE-1679

Why

Azure/ARO-HCP#6376 has created a 40-member DEV ARM-helper identity pool, but Boskos does not yet know about those resources. The inventory must roll out independently before #82980 can request two identities and rehearse the affected jobs.

What

• Add the aro-hcp-arm-helper-sp-dev Boskos resource type.
• Add 40 transparent resources named aro-hcp-arm-helper-sp-dev-0 through aro-hcp-arm-helper-sp-dev-39.
• Regenerate _boskos.yaml from generate-boskos.py.

The job lease declarations and provisioning behavior remain scoped to #82980.

Testing

• make boskos-config
• make check-boskos
• git diff --check

Summary by CodeRabbit

• Adds 40 transparent Boskos resources for the aro-hcp-arm-helper-sp-dev resource type.
• Regenerates the Boskos inventory so the resources are available for future CI job lease and provisioning changes.
• Validates the configuration with make boskos-config, make check-boskos, and git diff --check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.